Repository navigation
Commit 096c2ec
committed
test(webui): measure a surface the way a reader sees it
The gate measured a surface while it was still moving. The shared dialog
enters over 200ms, and a scan that runs during the entrance measures a surface
the reader never sees: the dialog's own backdrop is still transparent, and a
contrast finding is the difference between a settled background and a moving
one. The same scan reported 166 findings with the entrance running and 17 with
it settled - 149 of them were the dialog's own text, measured against a
background that was not there yet. The measurement waits for the animations
that are running now, which is the wait the shared-dialog measurements already
use, and it gives up rather than hanging on one that never finishes.
It also stops calling an item that a scroll boundary can bring back into view
"outside its surface". A modal with a fixed header and a scrolling body puts
what it shows below the fold, and that content is reachable by scrolling - the
contract a scroll boundary states, and the contract the clipped check above
already honoured. Six `models-provider-form` states failed on four attachment
labels the dialog's scrolling body holds below the fold.1 parent 6d4e810 commit 096c2ec
2 files changed
Lines changed: 57 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
690 | 691 | | |
691 | 692 | | |
692 | 693 | | |
| 694 | + | |
693 | 695 | | |
694 | 696 | | |
695 | 697 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
42 | 62 | | |
43 | 63 | | |
44 | 64 | | |
| |||
130 | 150 | | |
131 | 151 | | |
132 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
133 | 184 | | |
134 | 185 | | |
135 | | - | |
| 186 | + | |
136 | 187 | | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
| 188 | + | |
| 189 | + | |
144 | 190 | | |
145 | 191 | | |
146 | 192 | | |
| |||
193 | 239 | | |
194 | 240 | | |
195 | 241 | | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
| 242 | + | |
203 | 243 | | |
204 | 244 | | |
205 | 245 | | |
| |||
0 commit comments