Skip to content

Commit 8ebff58

Browse files
committed
Merge branch '4.x-dev' into 5.x-dev
2 parents b209160 + 702aa50 commit 8ebff58

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

CachedEntry.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,13 @@ public function __construct(string $userAgent, $clientHints, array $values)
3939
// We use some special parsers, which use the cached user agent result and parses it again using client hints
4040
if (!empty($clientHints) && $values['client']['type'] === 'browser') {
4141
$browserParser = new CachedBrowserParser($userAgent, $clientHints);
42+
$browserParser->setCachedResult($this->client);
4243
$this->client = $browserParser->parse();
4344
}
4445

4546
if (!empty($clientHints)) {
4647
$osParser = new CachedOperatingSystemParser($userAgent, $clientHints);
48+
$osParser->setCachedResult($this->os);
4749
$this->os = $osParser->parse();
4850
}
4951
}

lang/sq.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"DeviceDetectorCache": {
3-
"PluginDescription": "E bën më të shpejtë gjurmimin, duke pikasur prej një fshehtine shumë pajisje, sisteme operativë, robotë dhe shfletues."
3+
"PluginDescription": "E bën më të shpejtë ndjekjen, duke pikasur prej një fshehtine shumë pajisje, sisteme operativë, robotë dhe shfletues."
44
}
55
}

tests/Unit/DeviceDetectorCacheFactoryTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,9 @@ public function testGetInstanceFromCacheWithClientHints()
122122
'name' => 'Microsoft Edge',
123123
'version' => '98.0',
124124
'short_name' => 'PS',
125-
'engine' => 'Blink',
126-
'engine_version' => '97.0.4692.71',
125+
// empty because cached result doesn't contain it and engine won't be detected through client hints only
126+
'engine' => '',
127+
'engine_version' => '',
127128
'family' => 'Internet Explorer',
128129
];
129130

0 commit comments

Comments
 (0)