Merge pull request #70 from matomo-org/PG-3334-check-direct-dep

Added tests to check direct use of core dependencies, #PG-3334

Author: AltamashShaikh

.github/workflows/matomo-tests.yml

@@ -44,6 +44,8 @@ jobs:
         with:
           lfs: true
           persist-credentials: false
+      - name: Install package ripgrep
+        run: sudo apt-get install ripgrep
       - name: Run tests
         uses: matomo-org/github-action-tests@main
         with:

tests/System/CheckDirectDependencyUseCommandTest.php

@@ -0,0 +1,52 @@
+<?php
+/**
+ * Piwik - free/libre analytics platform
+ *
+ * @link http://piwik.org
+ * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+namespace Piwik\Plugins\DeviceDetectorCache\tests\System;
+
+use Piwik\Plugins\TestRunner\Commands\CheckDirectDependencyUse;
+use Piwik\Tests\Framework\TestCase\SystemTestCase;
+use Piwik\Version;
+use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Output\NullOutput;
+
+class CheckDirectDependencyUseCommandTest extends SystemTestCase
+{
+    public function testCommand()
+    {
+        if (version_compare(Version::VERSION, '5.0.3', '<=') && !file_exists(PIWIK_INCLUDE_PATH . '/plugins/TestRunner/Commands/CheckDirectDependencyUse.php')) {
+            $this->markTestSkipped('tests:check-direct-dependency-use is not available in this version');
+        }
+
+        $pluginName = 'DeviceDetectorCache';
+
+        $checkDirectDependencyUse = new CheckDirectDependencyUse();
+
+        $console = new \Piwik\Console(self::$fixture->piwikEnvironment);
+        $console->addCommands([$checkDirectDependencyUse]);
+        $command = $console->find('tests:check-direct-dependency-use');
+        $arguments = [
+            'command'    => 'tests:check-direct-dependency-use',
+            '--plugin' => $pluginName,
+            '--grep-vendor',
+        ];
+
+        $inputObject = new ArrayInput($arguments);
+        $command->run($inputObject, new NullOutput());
+
+        $this->assertEquals([
+            'Symfony\Component\Console' => [
+                'DeviceDetectorCache/tests/System/CheckDirectDependencyUseCommandTest.php'
+            ],
+            'DeviceDetector' => [
+                'DeviceDetectorCache/CachedEntry.php',
+                'DeviceDetectorCache/DeviceDetector/CachedBrowserParser.php',
+                'DeviceDetectorCache/DeviceDetector/CachedOperatingSystemParser.php',
+            ]
+        ], $checkDirectDependencyUse->usesFoundList[$pluginName]);
+    }
+}