Skip invalid post objects instead of failing the entire request

fixes #1048

Author: grishka

mastodon/build.gradle

@@ -13,8 +13,8 @@ android {
 		applicationId "org.joinmastodon.android"
 		minSdk 23
 		targetSdk 35
-		versionCode 153
-		versionName "2.12.0"
+		versionCode 154
+		versionName "2.11.5"
 		testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
 	}
 

mastodon/src/main/java/org/joinmastodon/android/api/MastodonAPIRequest.java

@@ -177,29 +177,29 @@ public void validateAndPostprocessResponse(T respObj, Response httpResponse) thr
 			throw new ObjectValidationException("Server response is empty");
 		}else if(respObj instanceof BaseModel){
 			((BaseModel) respObj).postprocess();
-		}else if(respObj instanceof List){
+		}else if(respObj instanceof List<?> respList){
 			if(removeUnsupportedItems){
-				Iterator<?> itr=((List<?>) respObj).iterator();
+				Iterator<?> itr=respList.iterator();
 				while(itr.hasNext()){
 					Object item=itr.next();
-					if(item instanceof BaseModel){
+					if(item instanceof BaseModel bm){
 						try{
-							((BaseModel) item).postprocess();
+							bm.postprocess();
 						}catch(ObjectValidationException x){
 							Log.w(TAG, "Removing invalid object from list", x);
 							itr.remove();
 						}
-					}
-				}
-				for(Object item:((List<?>) respObj)){
-					if(item instanceof BaseModel){
-						((BaseModel) item).postprocess();
+					}else if(item==null){
+						Log.w(TAG, "Removing null object from list");
+						itr.remove();
 					}
 				}
 			}else{
-				for(Object item:((List<?>) respObj)){
-					if(item instanceof BaseModel)
-						((BaseModel) item).postprocess();
+				for(Object item:respList){
+					if(item instanceof BaseModel bm)
+						bm.postprocess();
+					else if(item==null)
+						throw new ObjectValidationException("null item in list");
 				}
 			}
 		}

mastodon/src/main/java/org/joinmastodon/android/api/requests/accounts/GetAccountStatuses.java

@@ -33,6 +33,7 @@ public GetAccountStatuses(String id, String maxID, String minID, int limit, @Non
 		}
 		if(!TextUtils.isEmpty(hashtag))
 			addQueryParameter("tagged", hashtag);
+		removeUnsupportedItems=true;
 	}
 
 	public enum Filter{

mastodon/src/main/java/org/joinmastodon/android/api/requests/statuses/GetStatusEditHistory.java

@@ -15,6 +15,7 @@
 public class GetStatusEditHistory extends MastodonAPIRequest<List<Status>>{
 	public GetStatusEditHistory(String id){
 		super(HttpMethod.GET, "/statuses/"+id+"/history", new TypeToken<>(){});
+		removeUnsupportedItems=true;
 	}
 
 	@Override

mastodon/src/main/java/org/joinmastodon/android/api/requests/timelines/GetHashtagTimeline.java

@@ -16,5 +16,6 @@ public GetHashtagTimeline(String hashtag, String maxID, String minID, int limit)
 			addQueryParameter("min_id", minID);
 		if(limit>0)
 			addQueryParameter("limit", ""+limit);
+		removeUnsupportedItems=true;
 	}
 }

mastodon/src/main/java/org/joinmastodon/android/api/requests/timelines/GetHomeTimeline.java

@@ -18,5 +18,6 @@ public GetHomeTimeline(String maxID, String minID, int limit, String sinceID){
 			addQueryParameter("since_id", sinceID);
 		if(limit>0)
 			addQueryParameter("limit", ""+limit);
+		removeUnsupportedItems=true;
 	}
 }

mastodon/src/main/java/org/joinmastodon/android/api/requests/timelines/GetListTimeline.java

@@ -18,5 +18,6 @@ public GetListTimeline(String listID, String maxID, String minID, int limit, Str
 			addQueryParameter("limit", ""+limit);
 		if(sinceID!=null)
 			addQueryParameter("since_id", sinceID);
+		removeUnsupportedItems=true;
 	}
 }

mastodon/src/main/java/org/joinmastodon/android/api/requests/timelines/GetPublicTimeline.java

@@ -24,5 +24,6 @@ public GetPublicTimeline(boolean local, boolean remote, String maxID, String min
 			addQueryParameter("since_id", sinceID);
 		if(limit>0)
 			addQueryParameter("limit", limit+"");
+		removeUnsupportedItems=true;
 	}
 }

mastodon/src/main/java/org/joinmastodon/android/api/requests/trends/GetTrendingStatuses.java

@@ -14,5 +14,6 @@ public GetTrendingStatuses(int offset, int limit){
 			addQueryParameter("limit", ""+limit);
 		if(offset>0)
 			addQueryParameter("offset", ""+offset);
+		removeUnsupportedItems=true;
 	}
 }

mastodon/src/main/java/org/joinmastodon/android/model/Quote.java

@@ -3,18 +3,18 @@
 import com.google.gson.annotations.SerializedName;
 
 import org.joinmastodon.android.api.ObjectValidationException;
-import org.joinmastodon.android.api.RequiredField;
 import org.parceler.Parcel;
 
 @Parcel
 public class Quote extends BaseModel{
-	@RequiredField
 	public State state=State.UNAUTHORIZED;
 	public Status quotedStatus;
 	public String quotedStatusId;
 
 	@Override
 	public void postprocess() throws ObjectValidationException{
+		if(state==null)
+			state=State.UNAUTHORIZED;
 		super.postprocess();
 		if(quotedStatus!=null)
 			quotedStatus.postprocess();