Email template filter too agressive in 2.4.7-p9 , prevent style to be applied in preview

[SebFrango]

Preconditions and environment

• Magento version: 2.4.7-p9
• the filter used in Email template preview is too agressive and prevent the CSS style to be applied

Steps to reproduce

1 / Create an email marketing template with some styles in the style input and this call in the text input:
<style type="text/css">
{{var template_styles|raw}}
</style>
2/ try to preview the template from the listing email template view => the style is applied
3/ try to preview the template from the template editing view => the style won(t be applied

Expected result

the style should be apply when we preview the template from the template editing view

Actual result

the style is not applied when we preview the template from the template editing view

Additional information

I found where the issue comes from:
in the last security patch 2.4.7-p9, the add a filter on the text template in this file vendor/magento/module-email/Block/Adminhtml/Template/Preview.php, line 68 when we are in the case where the preview came from the editing view (so no id in the POST param).
Here the filter: $template->setTemplateText($this->_maliciousCode->filter($request->getParam('text')));

Because of tat , the style tag are removed from the text , so ther is no {{var template_styles|raw}} anymore, so the style are not applied anymore.

I have made a patch to fix this, si put it as attachment

email-template-preview-styles.patch

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @SebFrango. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[github-jira-sync-bot]

❌ You don't have permission to export this issue.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @SebFrango,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Could you please try to reproduce the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible and also please provide screenshots.

Thanks.