From 07525dc1f5f26a152433b61d8785012eecb68d6e Mon Sep 17 00:00:00 2001 From: David Green Date: Tue, 26 May 2026 19:49:31 +0100 Subject: [PATCH] [SelectionDAGBuilder] Replace asserts inside LLVM_DEBUG These assert were inside an LLVM_DEBUG macro, meaning they were very rarely if ever tested. The second "LowerFormalArguments emitted a value with the wrong type!" assert would fire in a number of tests so has been removed. The other was replaced with an all_of assert. --- llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index 579bff7d3ab60..05c75c484889e 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -12097,14 +12097,8 @@ void SelectionDAGISel::LowerArguments(const Function &F) { "LowerFormalArguments didn't return a valid chain!"); assert(InVals.size() == Ins.size() && "LowerFormalArguments didn't emit the correct number of values!"); - LLVM_DEBUG({ - for (unsigned i = 0, e = Ins.size(); i != e; ++i) { - assert(InVals[i].getNode() && - "LowerFormalArguments emitted a null value!"); - assert(EVT(Ins[i].VT) == InVals[i].getValueType() && - "LowerFormalArguments emitted a value with the wrong type!"); - } - }); + assert(all_of(InVals, [](SDValue InVal) { return InVal.getNode(); }) && + "LowerFormalArguments emitted a null value!"); // Update the DAG with the new chain value resulting from argument lowering. DAG.setRoot(NewRoot);