fix: genevetunnel key allocation

Author: cheina97

pkg/liqo-controller-manager/networking/internal-network/id/genevetunnel.go

@@ -38,7 +38,7 @@ func GetGeneveTunnelManager(ctx context.Context, cl client.Client) *Manager[uint
 
 		for i := range tunnelList.Items {
 			tunnel := &tunnelList.Items[i]
-			err = geneveTunnelManager.Configure(tunnel.Name, tunnel.Spec.ID)
+			err = geneveTunnelManager.Configure(client.ObjectKeyFromObject(tunnel).String(), tunnel.Spec.ID)
 			runtime.Must(err)
 		}
 	})

pkg/utils/network/geneve/netlink.go

@@ -15,6 +15,7 @@
 package geneve
 
 import (
+	"errors"
 	"fmt"
 	"net"
 
@@ -77,9 +78,10 @@ func CreateGeneveInterface(name string, local, remote net.IP, id uint32, disable
 		}
 	} else {
 		geneveLink = link.(*netlink.Geneve)
-		if !geneveLink.Remote.Equal(remote) || geneveLink.MTU != mtu || geneveLink.Dport != port {
-			klog.Warningf("geneve link already exists with different remote IP (%s -> %s), modifyng it",
-				geneveLink.Remote.String(), remote.String())
+		if !geneveLink.Remote.Equal(remote) || geneveLink.MTU != mtu || geneveLink.Dport != port || geneveLink.ID != id {
+			klog.Warningf("geneve link already exists with different parameters "+
+				"(remote: %s -> %s, id: %d -> %d, mtu: %d -> %d, dport: %d -> %d), modifying it",
+				geneveLink.Remote.String(), remote.String(), geneveLink.ID, id, geneveLink.MTU, mtu, geneveLink.Dport, port)
 			if err := netlink.LinkDel(geneveLink); err != nil {
 				return fmt.Errorf("cannot delete geneve link: %w", err)
 			}
@@ -119,6 +121,9 @@ func CreateGeneveInterface(name string, local, remote net.IP, id uint32, disable
 func ExistGeneveInterface(name string) netlink.Link {
 	link, err := netlink.LinkByName(name)
 	if err != nil {
+		if !errors.As(err, &netlink.LinkNotFoundError{}) {
+			klog.Warningf("geneve interface check failed: %v", err)
+		}
 		return nil
 	}
 	return link