Skip to content

Commit c9f14a3

Browse files
committed
docs: correct three ADR 0018 review-notes claims taken from the text layer
A third reading of the source package, from rendered page images rather than extracted text, found three wrong claims in the review notes. All three failed the same way: in this package the PDF text layer misplaces checkbox and Y/N columns, collapsing marks upward toward the first rows of a table and detaching answer columns from their items, so a filled form reads as a mostly-empty one. - The package is 73 pages, not 24. 24 was the tooling's page count. - One vendor's pump checklist has 3 of 20 items blank, not 14 - items 6, 12 and 20. Rotation direction and power consumption are both marked and initialled. Adds the genuine finding the wrong number was obscuring: the Date column is blank on all twenty rows of all four copies, so nothing on the form dates an individual check. - The hard N is not the PID-tuning line, which is marked pass with a note describing a defect and a workaround - that is an instance of R3, not R4. The real orphan failure is the line confirming automatic recovery from simulated power-loss events. The third correction reaches into the ADR: open question 7 was built on the PID example. The real line is a stronger case - empty note cell, arguably the most consequential line on the page, and the page was signed as a whole immediately afterwards with the failure on it. That sharpens where the QC flag belongs: at sign/freeze time alongside section 4's blank-result gate, not in the turnover package, which is far too late. A failed line with no linked punch item is the same class of defect as a blank line - one whose consequence has nowhere to go. Nothing structural changes. The ten observations hold, R2/R6/R7/R8 stand, R3-R5 remain open. Corrections are marked in place rather than silently applied, per this file's own rule.
1 parent d26e5fa commit c9f14a3

2 files changed

Lines changed: 64 additions & 7 deletions

File tree

‎docs/adr/0018-multi-vendor-startup-evidence-model.md‎

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -606,9 +606,28 @@ reasoning in [`0018-review-notes.md`](0018-review-notes.md) R3–R5.*
606606
because "conditions were not available" — not deferred, not N/A, not failed.
607607
Recommendation: a short closed vocabulary — `conditions_unavailable` ·
608608
`access_blocked` · `equipment_unavailable` · `out_of_scope` · `other` — so
609-
the package answers "why not" without a paragraph. Pair it with a turnover QC
610-
flag for a **failed line carrying no linked punch item** (the source has
611-
exactly one such orphan failure, appearing in no action-item list anywhere).
609+
the package answers "why not" without a paragraph. Pair it with a QC flag for
610+
a **failed line carrying no linked punch item**.
611+
612+
**Example corrected 2026-08-04 (third reading).** This question previously
613+
cited a PID-tuning line as the orphan failure; that line is marked **pass**,
614+
and its note describes a defect plus a workaround — an instance of open
615+
question 6, not this one. The real orphan failure is the line confirming
616+
**automatic recovery from simulated power-loss events**, and it is a stronger
617+
case: its note cell is **empty**, it is arguably the most consequential line
618+
on that page, and the page was **signed as a whole** immediately afterwards
619+
with the failure on it, appearing in no action-item list anywhere in the
620+
package.
621+
622+
**Consequence for where the flag fires.** An orphan failure that survives a
623+
signature is not caught by a turnover-package check — turnover is far too
624+
late, and the signature already happened. The flag belongs at **sign/freeze**
625+
time alongside §4's blank-result gate: §4 already refuses to sign a check
626+
carrying a blank line, and a **failed line with no linked punch item is the
627+
same class of defect** — a line whose consequence has nowhere to go. Whether
628+
that hard-blocks the signature (as blanks do) or warns loudly is the open
629+
part; §4's gate is the precedent, and the field evidence says a warning would
630+
have been clicked through.
612631
8. **Structural vs. situational N/A** ([R5](0018-review-notes.md#r5--required-na_reason-will-be-heavier-than-the-adr-assumes--open)).
613632
§4 requires `na_reason` on every N/A. The source marks two lines N/A on
614633
*every* unit of a type — a property of the equipment subtype, not of the

‎docs/adr/0018-review-notes.md‎

Lines changed: 42 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,38 @@ change is four refinements folded into the ADR (R2, R6, R7, R8) and three
2222
questions the summary did not raise (R3–R5). R1 proposed reversing a
2323
recommendation and was **decided against** by the maintainer.
2424

25-
**What was read.** A 24-page compiled startup submittal covering five
25+
**What was read.** A **73-page** compiled startup submittal covering five
2626
independent vendors, in five mutually incompatible form formats: a rotary-lobe
2727
pump vendor's four-page start-up report (×4 units), a blower vendor's seven-page
2828
service order (×2 units), a valve-actuator vendor's inspection reports (×6
2929
units), an MBR system supplier's three field service reports (dry checks, I/O
3030
checks, clean water), and three clean-water checklists including a pre-run gate.
3131
No project, company, or person is identified in these notes.
3232

33+
**Corrections — third reading, 2026-08-04.** Three claims in these notes were
34+
wrong, and all three failed the same way: they were taken from the PDF's
35+
**extracted text layer** rather than from rendered pages. In this package the
36+
text layer misplaces checkbox and Y/N columns — marks collapse upward toward
37+
the first rows of a table, and answer columns detach from their items — so a
38+
filled form reads as a mostly-empty one. The source was re-read from rendered
39+
page images and the corrections are marked at each site below.
40+
41+
| Claim as written | Correct | Where |
42+
|---|---|---|
43+
| "A 24-page compiled startup submittal" | **73 pages** — 24 was the tooling's page count, not the file's | fixed above |
44+
| "14 of 20 checklist items blank on all four copies … including rotation direction and power consumption" | **3 of 20** — items 6, 12 and 20. Rotation direction (item 7) and power consumption (item 19) are both marked and initialled | §4 row in the confirmation table |
45+
| "one clean-water logic line is answered a hard **N** — a PID loop not tuned" | The PID line is marked **Y**. The **N** is the line covering **automatic recovery from simulated power-loss events** | R4 |
46+
47+
The third correction is the one that matters beyond accuracy: **ADR 0018's open
48+
question 7 is built on that example**, and the real line is both more
49+
consequential and a cleaner illustration of the point. It is corrected there
50+
too.
51+
52+
Nothing structural changes. The ten observations still hold, R2 / R6 / R7 / R8
53+
stand as folded in, and R3–R5 remain open. Method note for whoever reads a
54+
scanned or form-heavy source next: **render the pages.** A text layer is a
55+
convenience, not the document.
56+
3357
---
3458

3559
## R1 — Per-leg readings: the ADR's recommendation is **reversed** · **DECIDED — original recommendation upheld**
@@ -152,11 +176,25 @@ them. That is not `deferred` (nothing was moved to a later phase, and no
152176
follow-up was named), not `na` (the check applies), and not `fail`. It is
153177
"not performed, because the plant could not be put in the state required."
154178

155-
Separately, one clean-water logic line is answered a hard **N** — a PID loop
156-
not tuned — and appears in **no** action-item list in the package. A bare `fail`
179+
Separately, one clean-water logic line is answered a hard **N** — ~~a PID loop
180+
not tuned~~ **corrected: the line confirming that the system recovers
181+
automatically from simulated power-loss events, with no manual operator
182+
action** — and appears in **no** action-item list in the package. A bare `fail`
157183
with no punch item is exactly the leak the ball-in-court work is meant to close
158184
(see R5's neighbour finding below).
159185

186+
**Correction, third reading 2026-08-04.** The PID line is marked **Y**, not N;
187+
its *note* describes an unresolved equipment defect and prescribes a speed
188+
limit as a workaround, which makes it an instance of **R3** (pass with
189+
exception), not of this comment. The genuine bare failure is the power-loss
190+
recovery line, and it is a stronger example in three ways: its note cell is
191+
**empty**, so there is no prose for a reader to fall back on; it is arguably
192+
the most consequential line on the page; and the page was **signed as a whole**
193+
immediately afterwards. That last point sharpens the recommendation below — the
194+
QC flag has to fire at **sign/freeze** time, not only in the turnover package,
195+
because a signature over a set of lines is plainly not a signature over their
196+
content.
197+
160198
**Recommendation:** a short closed vocabulary on `not_performed` —
161199
`conditions_unavailable` · `access_blocked` · `equipment_unavailable` ·
162200
`out_of_scope` · `other` — is cheap and makes the turnover package answer
@@ -246,7 +284,7 @@ assumed:
246284
| ADR section | Source evidence |
247285
|---|---|
248286
| §2 deferral | Two "will be checked during clean water with [vendor] rep" annotations, plus one "finish during clean water" |
249-
| §4 blanks | 14 of 20 checklist items blank on **all four** copies of one vendor's pump form, including rotation direction and power consumption |
287+
| §4 blanks | ~~14 of 20~~ **3 of 20** checklist items blank on **all four** copies of one vendor's pump form — items 6, 12 and 20 (optional safety equipment, air relieved from piping, and the O&M inspection schedule: plausibly N/A, definitely-performed-or-not, and a deliverable rather than a field check — three meanings, one blank cell). Rotation direction and power consumption are both marked and initialled. Separately, the form's **Date column is blank on all twenty rows** of all four copies; only initials were entered, so nothing on the form dates an individual check |
250288
| §5 vendor evidence | Five vendors, five incompatible formats, one of them a seven-page service order with on-site/off-site times **and break duration** |
251289
| §6 ball-in-court | The MBR supplier's reports are *organized* by responsible party — three standing sections per report |
252290
| §6 scope gap | Three separate instances, including an instrument explicitly "not in scope but would need to be set up before turning plant online" |

0 commit comments

Comments
 (0)