From ba466b8ddec3a2b23375832c9dab27e9efbbc1a7 Mon Sep 17 00:00:00 2001 From: Boris Grozev Date: Tue, 25 Aug 2026 15:03:27 -0500 Subject: [PATCH] fix: increment jibri_no_instance_failures on AllBusy too Prod data shows the no-instance branch is rarely hit because some jibri instances always stay connected; StartException.AllBusy (no matching instance available, e.g. due to region scoping) was the actual dominant failure path and was not being counted. --- jicofo/src/main/java/org/jitsi/jicofo/jibri/JibriSession.java | 2 +- jicofo/src/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/jicofo/src/main/java/org/jitsi/jicofo/jibri/JibriSession.java b/jicofo/src/main/java/org/jitsi/jicofo/jibri/JibriSession.java index 2d7a8590c4..4279f5a1eb 100644 --- a/jicofo/src/main/java/org/jitsi/jicofo/jibri/JibriSession.java +++ b/jicofo/src/main/java/org/jitsi/jicofo/jibri/JibriSession.java @@ -295,7 +295,7 @@ synchronized public void start() { JibriStats.sessionFailed(getJibriType()); - if (e instanceof StartException.NotAvailable) + if (e instanceof StartException.NotAvailable || e instanceof StartException.AllBusy) { JibriStats.noInstanceFailed(); } diff --git a/jicofo/src/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt b/jicofo/src/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt index 4b4020cbf9..87c3829b62 100644 --- a/jicofo/src/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt +++ b/jicofo/src/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt @@ -44,7 +44,7 @@ class JibriStats { @JvmField val noInstanceFailures = JicofoMetricsContainer.instance.registerCounter( "jibri_no_instance_failures", - "Number of failures to start a jibri session because no instance was available" + "Number of failures to start a jibri session because no instance was available or all instances were busy" ) @JvmField