Fully cleanup source-map-support#15233
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
eyalroth
force-pushed
the
fix-memory-leak-sourcemap
branch
from
fb7358c to
47de10c
Compare
| let e = error; | ||
| while (typeof e === 'object' && 'stack' in e) { | ||
| e.stack; | ||
| e = e?.cause ?? {}; |
There was a problem hiding this comment.
do we need the ?? part? the while condition does a typeof which should be fine? Or is it to guard against null?
There was a problem hiding this comment.
@SimenB Pretty much, yeah.
Maybe it's better to add the null protection explicitly to the while condition; this way, it would also protect against a null been thrown for some reason.
…rce-map-support
eyalroth
force-pushed
the
fix-memory-leak-sourcemap
branch
from
47de10c to
338243a
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Summary
Split from #15215. Please see that PR's description and comments for more information.