Missing return statement in clientrpc error handling

[ann0see]

jamulus/src/clientrpc.cpp

Line 202 in 0db5544

CRpcServer::CreateJsonRpcError ( CRpcServer::iErrInvalidParams, "Invalid params: directory is not a valid socket address" );

seems to be missing a return statement. So we set result == ok which is not correct in case of errors.
Found by local AI review

[pljones]

Could you add a bit more detail - steps to reproduce, etc.

[ann0see]

It's just an observation. If jamulusclient/pollServerList executes, and NetworkUtil::ParseNetworkAddress returns false, respones["error"] is set to an error message. However, response["result"] is also set to ok, as the else does not have a return statement.