From 1ecf4b091429ac9908a279d17917ec56061690b0 Mon Sep 17 00:00:00 2001 From: Stefan Hipfel Date: Mon, 11 May 2026 10:20:37 +0200 Subject: [PATCH 1/3] Fix nil error logging in probe registration Fixes #785 Signed-off-by: Stefan Hipfel --- internal/probe/probe.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/probe/probe.go b/internal/probe/probe.go index 4217756d2..05b274871 100644 --- a/internal/probe/probe.go +++ b/internal/probe/probe.go @@ -7,6 +7,8 @@ import ( "bytes" "context" "encoding/json" + "fmt" + "io" "net/http" "time" @@ -221,7 +223,8 @@ func (a *Agent) registerServer(ctx context.Context) error { }() if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated { - a.log.Error(err, "Failed to register server", "url", a.RegistryURL) + body, _ := io.ReadAll(io.LimitReader(resp.Body, 1024)) + a.log.Error(fmt.Errorf("HTTP %d: %s", resp.StatusCode, string(body)), "Failed to register server", "url", a.RegistryURL) return false, nil } From ef8ba72a5a11e75d8e0f859da541701ab4edd48d Mon Sep 17 00:00:00 2001 From: Stefan Hipfel Date: Fri, 15 May 2026 09:57:13 +0200 Subject: [PATCH 2/3] fixes CodeRabbitAI issue Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Stefan Hipfel --- internal/probe/probe.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/internal/probe/probe.go b/internal/probe/probe.go index 05b274871..f311f4eb7 100644 --- a/internal/probe/probe.go +++ b/internal/probe/probe.go @@ -223,9 +223,14 @@ func (a *Agent) registerServer(ctx context.Context) error { }() if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated { - body, _ := io.ReadAll(io.LimitReader(resp.Body, 1024)) + body, readErr := io.ReadAll(io.LimitReader(resp.Body, 1024)) + if readErr != nil { + a.log.Error(fmt.Errorf("HTTP %d: failed to read response body: %w", resp.StatusCode, readErr), "Failed to register server", "url", a.RegistryURL) + return false, nil + } a.log.Error(fmt.Errorf("HTTP %d: %s", resp.StatusCode, string(body)), "Failed to register server", "url", a.RegistryURL) return false, nil + return false, nil } a.log.Info("Server registered") From 8fd18f72aad5855af5830170d10a308c8042cf0d Mon Sep 17 00:00:00 2001 From: Stefan Hipfel Date: Tue, 19 May 2026 14:16:29 +0200 Subject: [PATCH 3/3] Fix unreachable code lint error in probe registration Remove duplicate return statement on line 233 that was causing govet unreachable code error. The duplicate return was accidentally added and made the code after it unreachable. Signed-off-by: Stefan Hipfel --- internal/probe/probe.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/probe/probe.go b/internal/probe/probe.go index f311f4eb7..e9529908e 100644 --- a/internal/probe/probe.go +++ b/internal/probe/probe.go @@ -230,7 +230,6 @@ func (a *Agent) registerServer(ctx context.Context) error { } a.log.Error(fmt.Errorf("HTTP %d: %s", resp.StatusCode, string(body)), "Failed to register server", "url", a.RegistryURL) return false, nil - return false, nil } a.log.Info("Server registered")