From cf927895c42522a468be20e2814d6e64e11e8634 Mon Sep 17 00:00:00 2001 From: mahesh-naxa Date: Wed, 1 May 2024 17:28:15 +0545 Subject: [PATCH 1/2] infra: Updates to dockerfile & circleci images for node v18 upgrade --- .circleci/config.yml | 6 +++--- scripts/docker/Dockerfile.frontend | 2 +- scripts/docker/Dockerfile.frontend_development | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d8649e5cba..2f3d31280b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,7 +10,7 @@ jobs: frontend-code-test: resource_class: large docker: - - image: cimg/node:16.20 + - image: cimg/node:18.19.1 working_directory: /home/circleci/tasking-manager steps: - checkout @@ -184,7 +184,7 @@ jobs: working_directory: /home/circleci/tasking-manager resource_class: medium docker: - - image: cimg/python:3.10.7-node + - image: cimg/node:18.19.1 steps: - checkout - aws-cli/setup: @@ -237,7 +237,7 @@ jobs: working_directory: /home/circleci/tasking-manager resource_class: large docker: - - image: cimg/python:3.10.7-node + - image: cimg/node:18.19.1 parameters: stack_name: description: "the name of the stack for cfn-config" diff --git a/scripts/docker/Dockerfile.frontend b/scripts/docker/Dockerfile.frontend index 70293a48f7..b78bb57413 100644 --- a/scripts/docker/Dockerfile.frontend +++ b/scripts/docker/Dockerfile.frontend @@ -1,4 +1,4 @@ -FROM node:18 as build +FROM node:18.19.1 as build WORKDIR /usr/src/app/frontend COPY frontend . diff --git a/scripts/docker/Dockerfile.frontend_development b/scripts/docker/Dockerfile.frontend_development index 57e2faa06a..8fb81c9006 100644 --- a/scripts/docker/Dockerfile.frontend_development +++ b/scripts/docker/Dockerfile.frontend_development @@ -1,4 +1,4 @@ -FROM node:18 +FROM node:18.19.1 WORKDIR /usr/src/app From 4dd471e7b567b91994a105913641042d47428535 Mon Sep 17 00:00:00 2001 From: mahesh-naxa Date: Wed, 1 May 2024 17:28:59 +0545 Subject: [PATCH 2/2] docs: updated version docs to v18 --- docs/developers/development-setup.md | 2 +- frontend/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/developers/development-setup.md b/docs/developers/development-setup.md index 6585506519..4e1f1a0bde 100644 --- a/docs/developers/development-setup.md +++ b/docs/developers/development-setup.md @@ -184,7 +184,7 @@ The client is the front-end user interface of the Tasking Manager. It is based o #### Dependencies The following dependencies must be available _globally_ on your system: -* Download and install [NodeJS LTS v12+](https://nodejs.org/en/) and [yarn](https://classic.yarnpkg.com/en/docs/install) +* Download and install [Node 18.xx](https://nodejs.org/en/download) and [yarn](https://classic.yarnpkg.com/en/docs/install) * Go into the `frontend` directory and execute `yarn`. #### Available Scripts diff --git a/frontend/package.json b/frontend/package.json index ec4a43ced1..fe4a9f41af 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -140,6 +140,6 @@ ] }, "volta": { - "node": "16.20.0" + "node": "18.19.1" } }