From cbac0700b74b5a2f39920e15c85ee5242c040fb8 Mon Sep 17 00:00:00 2001
From: webard <b.gajda@webard.me>
Date: Thu, 24 Sep 2026 21:16:26 +0200
Subject: [PATCH] fix: give the drag handle and the sub-navigation checkbox
 accessible names
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The drag handle was an icon-only button with no name, announced as just
"button". It is now labelled like Filament's own handles — Filament's
translated "Move" plus the view's name. The sub-navigation checkbox had
only a title, identical in every row; its aria-label now names the view.
Both reuse existing translations, so no new strings.
---
 .../livewire/saved-views-control.blade.php    |  5 ++++
 tests/Feature/AccessibleControlsTest.php      | 24 +++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 tests/Feature/AccessibleControlsTest.php

diff --git a/resources/views/livewire/saved-views-control.blade.php b/resources/views/livewire/saved-views-control.blade.php
index 3769b2b..0eb9d99 100644
--- a/resources/views/livewire/saved-views-control.blade.php
+++ b/resources/views/livewire/saved-views-control.blade.php
@@ -44,6 +44,8 @@ class="fi-checkbox-input"
                                     @checked($view->submenu_visible)
                                     wire:change="toggleSubmenu('{{ $view->id }}')"
                                     title="{{ __('filament-saved-views::saved-views.submenu_visible') }}"
+                                    {{-- The title alone read the same in every row; name the view too. --}}
+                                    aria-label="{{ __('filament-saved-views::saved-views.submenu_visible') }}: {{ $view->label }}"
                                 />
 
                                 <a
@@ -60,9 +62,12 @@ class="fi-checkbox-input"
                             {{ ($this->editViewAction)(['id' => $view->id]) }}
                             {{ ($this->deleteViewAction)(['id' => $view->id]) }}
 
+                            {{-- Labelled like Filament's own drag handles: its translated "Move" plus
+                                 what moves (the column manager does "Reorder column" + the column name). --}}
                             <button
                                 x-sortable-handle
                                 x-on:click.stop
+                                aria-label="{{ __('filament-forms::components.builder.actions.reorder.label') }} {{ $view->label }}"
                                 class="fi-fm-sv-handle"
                                 type="button"
                             >
diff --git a/tests/Feature/AccessibleControlsTest.php b/tests/Feature/AccessibleControlsTest.php
new file mode 100644
index 0000000..a16834d
--- /dev/null
+++ b/tests/Feature/AccessibleControlsTest.php
@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+$template = fn (): string => (string) file_get_contents(dirname(__DIR__, 2) . '/resources/views/livewire/saved-views-control.blade.php');
+
+it('names the drag handle after the view it moves', function () use ($template): void {
+    // An icon-only button with no name is announced as just "button". Filament labels its own drag
+    // handles with its translated "Move" / "Reorder column" plus what moves; this does the same.
+    expect($template())->toContain('aria-label="{{ __(\'filament-forms::components.builder.actions.reorder.label\') }} {{ $view->label }}"');
+});
+
+it('names the sub-navigation checkbox after its view', function () use ($template): void {
+    // The title alone read the same in every row.
+    expect($template())->toContain('aria-label="{{ __(\'filament-saved-views::saved-views.submenu_visible\') }}: {{ $view->label }}"');
+});
+
+it('resolves the borrowed Filament label in every locale the package ships', function (): void {
+    foreach (glob(dirname(__DIR__, 2) . '/resources/lang/*', GLOB_ONLYDIR) ?: [] as $directory) {
+        $label = trans('filament-forms::components.builder.actions.reorder.label', [], basename($directory));
+
+        expect($label)->toBeString()->not->toBe('filament-forms::components.builder.actions.reorder.label');
+    }
+});