From bf7a16a1bf742c1eaaa2bb1cceae1914368b26db Mon Sep 17 00:00:00 2001 From: Himanshu Gohel <1551217+hgohel@users.noreply.github.com> Date: Tue, 7 Jul 2026 17:45:31 -0400 Subject: [PATCH 1/3] Add check for stale files in POTFILES.in When` intltool-update -m` finds file entries in POTFILES.in which no longer exist, it logs those to `notexist`. If that file is file, CI will now treat that as an error as well. --- .github/workflows/gramps-ci.yml | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gramps-ci.yml b/.github/workflows/gramps-ci.yml index 57419871ff..7104f6de58 100644 --- a/.github/workflows/gramps-ci.yml +++ b/.github/workflows/gramps-ci.yml @@ -81,10 +81,20 @@ jobs: run: | cd po intltool-update -m - if [ -f "missing" ]; then - echo "ERROR - A new file is not listed in either POTFILES.in or POTFILES.skip"; - exit 1; - fi + missing_found=0 + notexist_found=0 + [[ -s missing ]] && missing_found=1 + [[ -s notexist ]] && notexist_found=1 + if [[ $missing_found -eq 1 && $notexist_found -eq 1 ]]; then + echo "ERROR - A new file is not listed in either POTFILES.in or POTFILES.skip." + echo "ERROR: stale entries in POTFILES.in that no longer exist." + exit 1 + elif [[ $notexist_found -eq 1 ]]; then + echo "ERROR: POTFILES.in lists files that no longer exist." + exit 1 + elif [[ $missing_found -eq 1 ]]; then + echo "ERROR - A new file is not listed in either POTFILES.in or POTFILES.skip." + exit 1 pypi-installer: name: PyPI installer tests (${{ matrix.os }}) From 3f5600a43f26d547996326c877f664beab833ad4 Mon Sep 17 00:00:00 2001 From: Himanshu Gohel <1551217+hgohel@users.noreply.github.com> Date: Tue, 7 Jul 2026 18:26:35 -0400 Subject: [PATCH 2/3] Convert from bash to sh syntax. --- .github/workflows/gramps-ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/gramps-ci.yml b/.github/workflows/gramps-ci.yml index 7104f6de58..17aeab0141 100644 --- a/.github/workflows/gramps-ci.yml +++ b/.github/workflows/gramps-ci.yml @@ -83,16 +83,16 @@ jobs: intltool-update -m missing_found=0 notexist_found=0 - [[ -s missing ]] && missing_found=1 - [[ -s notexist ]] && notexist_found=1 - if [[ $missing_found -eq 1 && $notexist_found -eq 1 ]]; then + [ -s missing ] && missing_found=1 + [ -s notexist ] && notexist_found=1 + if [ $missing_found -eq 1 ] && [ $notexist_found -eq 1 ]; then echo "ERROR - A new file is not listed in either POTFILES.in or POTFILES.skip." echo "ERROR: stale entries in POTFILES.in that no longer exist." exit 1 - elif [[ $notexist_found -eq 1 ]]; then + elif [ $notexist_found -eq 1 ]; then echo "ERROR: POTFILES.in lists files that no longer exist." exit 1 - elif [[ $missing_found -eq 1 ]]; then + elif [ $missing_found -eq 1 ]; then echo "ERROR - A new file is not listed in either POTFILES.in or POTFILES.skip." exit 1 From d8429b77e21b1efae7f18bc46fa9cf078c20f461 Mon Sep 17 00:00:00 2001 From: Himanshu Gohel <1551217+hgohel@users.noreply.github.com> Date: Tue, 7 Jul 2026 18:35:22 -0400 Subject: [PATCH 3/3] Fix syntax error --- .github/workflows/gramps-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/gramps-ci.yml b/.github/workflows/gramps-ci.yml index 17aeab0141..b486806a59 100644 --- a/.github/workflows/gramps-ci.yml +++ b/.github/workflows/gramps-ci.yml @@ -95,6 +95,7 @@ jobs: elif [ $missing_found -eq 1 ]; then echo "ERROR - A new file is not listed in either POTFILES.in or POTFILES.skip." exit 1 + fi pypi-installer: name: PyPI installer tests (${{ matrix.os }})