[Feat] Enable LTO

Signed-off-by: ZhouGuangyuan <zhouguangyuan.xian@gmail.com>

Author: zhouguangyuan0718

_demo/embed/targetsbuild/build.sh

@@ -111,6 +111,7 @@ case "$test_dir" in
 			"riscv32"
 			"riscv64"
 			"rp2040"
+			"nintendoswitch" # undefined symbol under lto, should not work when no-lto
 		)
 		;;
 	defer)

cl/_testdata/cpkg/out.ll

@@ -4,13 +4,13 @@ source_filename = "github.com/goplus/llgo/cl/_testdata/cpkg"
 @llvm.used = appending constant [2 x ptr] [ptr @Double, ptr @add], section "llvm.metadata"
 @"github.com/goplus/llgo/cl/_testdata/cpkg.init$guard" = global i1 false, align 1
 
-define double @Double(double %0) {
+define dllexport double @Double(double %0) {
 _llgo_0:
   %1 = fmul double 2.000000e+00, %0
   ret double %1
 }
 
-define i64 @add(i64 %0, i64 %1) {
+define dllexport i64 @add(i64 %0, i64 %1) {
 _llgo_0:
   %2 = call i64 @"github.com/goplus/llgo/cl/_testdata/cpkg.add"(i64 %0, i64 %1)
   ret i64 %2

go.sum

@@ -1,5 +1,7 @@
 github.com/creack/goselect v0.1.2 h1:2DNy14+JPjRBgPzAd1thbQp4BSIihxcBf0IXhQXDRa0=
 github.com/creack/goselect v0.1.2/go.mod h1:a/NhLweNvqIYMuxcMOuWY516Cimucms3DglDzQP3hKY=
+github.com/creack/goselect v0.1.3 h1:MaGNMclRo7P2Jl21hBpR1Cn33ITSbKP6E49RtfblLKc=
+github.com/creack/goselect v0.1.3/go.mod h1:a/NhLweNvqIYMuxcMOuWY516Cimucms3DglDzQP3hKY=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=

internal/build/plan9asm.go

@@ -254,6 +254,10 @@ func filterPlan9AsmFuncs(pkgPath, goos, goarch string, funcs []plan9asm.Func, re
 		if pkgPath == "syscall" && goos == "linux" && (goarch == "arm64" || goarch == "amd64") && strings.HasSuffix(resolved, "rawVforkSyscall") {
 			continue
 		}
+		if pkgPath == "syscall" && goos == "darwin" && (goarch == "arm64" || goarch == "amd64") &&
+			(strings.HasSuffix(resolved, "RawSyscall") || strings.HasSuffix(resolved, "RawSyscall6")) {
+			continue
+		}
 		keep = append(keep, fn)
 	}
 	return keep

internal/crosscompile/crosscompile.go

@@ -225,8 +225,9 @@ func use(goos, goarch string, wasiThreads, forceEspClang bool) (export Export, e
 			"-Wl,--error-limit=0",
 			"-fuse-ld=lld",
 			// Enable ICF (Identical Code Folding) to reduce binary size
-			"-Xlinker",
-			"--icf=safe",
+			"-Wl,--icf=safe",
+			// Enable ThinLTO, Using default lto kind(thinlto).
+			"-Wl,--lto-O0",
 		}
 		if clangRoot != "" {
 			clangLib := filepath.Join(clangRoot, "lib")
@@ -249,6 +250,7 @@ func use(goos, goarch string, wasiThreads, forceEspClang bool) (export Export, e
 		export.CCFLAGS = []string{
 			"-Qunused-arguments",
 			"-Wno-unused-command-line-argument",
+			"-flto=thin",
 		}
 
 		// Add sysroot for macOS only
@@ -499,6 +501,13 @@ func UseTarget(targetName string) (export Export, err error) {
 	expandedCFlags := env.ExpandEnvSlice(config.CFlags, envs)
 	cflags = append(cflags, expandedCFlags...)
 
+	if config.Linker == "ld.lld" {
+		// Enable ThinLTO, Using default lto kind(thinlto).
+		ldflags = append(ldflags, "--lto-O0")
+		cflags = append(cflags, "-flto=thin")
+		ccflags = append(ccflags, "-flto=thin")
+	}
+
 	// The following parameters are inspired by tinygo/builder/library.go
 	// Handle CPU configuration
 	if cpu != "" {
@@ -545,6 +554,8 @@ func UseTarget(targetName string) (export Export, err error) {
 		ccflags = append(ccflags, "-fforce-enable-int128")
 	case "riscv64":
 		ccflags = append(ccflags, "-march=rv64gc")
+		// codegen option should be added to ldflags for lto
+		ldflags = append(ldflags, "-mllvm", "-march=rv64gc")
 	case "mips":
 		ccflags = append(ccflags, "-fno-pic")
 	}
@@ -574,9 +585,13 @@ func UseTarget(targetName string) (export Export, err error) {
 	// Handle code generation configuration
 	if config.CodeModel != "" {
 		ccflags = append(ccflags, "-mcmodel="+config.CodeModel)
+		// codegen option should be added to ldflags for lto
+		ldflags = append(ldflags, "-mllvm", "-code-model="+config.CodeModel)
 	}
 	if config.TargetABI != "" {
 		ccflags = append(ccflags, "-mabi="+config.TargetABI)
+		// codegen option should be added to ldflags for lto
+		ldflags = append(ldflags, "-mllvm", "-target-abi="+config.TargetABI)
 	}
 	if config.RelocationModel != "" {
 		switch config.RelocationModel {

ssa/datastruct.go

@@ -342,6 +342,10 @@ func (b Builder) Slice(x, low, high, max Expr) (ret Expr) {
 	if lowIsNil {
 		low = prog.IntVal(0, prog.Int())
 	}
+	low = b.fitIntSize(low)
+	if !high.IsNil() {
+		high = b.fitIntSize(high)
+	}
 	switch t := x.raw.Type.Underlying().(type) {
 	case *types.Basic:
 		if t.Kind() != types.String {
@@ -382,6 +386,7 @@ func (b Builder) Slice(x, low, high, max Expr) (ret Expr) {
 	if max.IsNil() {
 		max = nCap
 	}
+	max = b.fitIntSize(max)
 	ret.impl = b.InlineCall(b.Pkg.rtFunc("NewSlice3"), base, nEltSize, nCap, low, high, max).impl
 	return
 }

ssa/decl.go

@@ -211,6 +211,10 @@ func (p Package) NewFuncEx(name string, sig *types.Signature, bg Background, has
 	if instantiated {
 		fn.SetLinkage(llvm.LinkOnceAnyLinkage)
 	}
+	if p.Prog.requiresFramePointer() {
+		attr := p.mod.Context().CreateStringAttribute("frame-pointer", "all")
+		fn.AddFunctionAttr(attr)
+	}
 	if p.isExportName(name) {
 		p.markLLVMUsed(fn)
 	}
@@ -345,6 +349,10 @@ func (p Function) Block(idx int) BasicBlock {
 	return p.blks[idx]
 }
 
+func (p Program) requiresFramePointer() bool {
+	return p.target != nil && p.target.GOOS == "darwin" && p.target.GOARCH == "arm64"
+}
+
 // SetRecover sets the recover block for the function.
 func (p Function) SetRecover(blk BasicBlock) {
 	p.recov = blk

ssa/ssa_test.go

@@ -133,6 +133,36 @@ func TestNewFuncExLLVMUsed(t *testing.T) {
 	}
 }
 
+func TestNewFuncExFramePointerAttrOnDarwinArm64(t *testing.T) {
+	prog := NewProgram(&Target{GOOS: "darwin", GOARCH: "arm64"})
+	pkg := prog.NewPackage("main", "main")
+	sig := types.NewSignatureType(nil, nil, nil, nil, nil, false)
+
+	fn := pkg.NewFunc("Foo", sig, InGo)
+	attr := fn.impl.GetStringAttributeAtIndex(-1, "frame-pointer")
+	if attr.IsNil() {
+		t.Fatal("missing frame-pointer function attribute")
+	}
+	if got := pkg.String(); !strings.Contains(got, `"frame-pointer"="all"`) {
+		t.Fatalf("module missing frame-pointer attribute:\n%s", got)
+	}
+}
+
+func TestNewFuncExFramePointerAttrNotForcedOnOtherTargets(t *testing.T) {
+	prog := NewProgram(&Target{GOOS: "linux", GOARCH: "amd64"})
+	pkg := prog.NewPackage("main", "main")
+	sig := types.NewSignatureType(nil, nil, nil, nil, nil, false)
+
+	fn := pkg.NewFunc("Foo", sig, InGo)
+	attr := fn.impl.GetStringAttributeAtIndex(-1, "frame-pointer")
+	if !attr.IsNil() {
+		t.Fatal("unexpected frame-pointer function attribute")
+	}
+	if got := pkg.String(); strings.Contains(got, `"frame-pointer"="all"`) {
+		t.Fatalf("unexpected frame-pointer attribute in module:\n%s", got)
+	}
+}
+
 func TestSetBlock(t *testing.T) {
 	defer func() {
 		if r := recover(); r == nil {