Address sixteenth review: docs regex, fan_in try/finally, hyphenated dot-path keys

- PUBLISHING.md: update ID regex docs to match implementation (single-char OK)
- FanInStep: wrap expression evaluation in try/finally for context.fan_in
- Expression dot-path: allow hyphens in keys before list index (e.g. run-tests[0])

Author: mnriem

src/specify_cli/workflows/expressions.py

@@ -71,7 +71,7 @@ def _resolve_dot_path(obj: Any, path: str) -> Any:
     current = obj
     for part in parts:
         # Handle list indexing: name[0]
-        idx_match = re.match(r"^(\w+)\[(\d+)\]$", part)
+        idx_match = re.match(r"^([\w-]+)\[(\d+)\]$", part)
         if idx_match:
             key, idx = idx_match.group(1), int(idx_match.group(2))
             if isinstance(current, dict):

src/specify_cli/workflows/steps/fan_in/__init__.py

@@ -35,14 +35,15 @@ def execute(self, config: dict[str, Any], context: StepContext) -> StepResult:
         context.fan_in = {"results": results}
         resolved_output: dict[str, Any] = {"results": results}
 
-        for key, expr in output_config.items():
-            if isinstance(expr, str) and "{{" in expr:
-                resolved_output[key] = evaluate_expression(expr, context)
-            else:
-                resolved_output[key] = expr
-
-        # Restore previous fan_in state
-        context.fan_in = prev_fan_in
+        try:
+            for key, expr in output_config.items():
+                if isinstance(expr, str) and "{{" in expr:
+                    resolved_output[key] = evaluate_expression(expr, context)
+                else:
+                    resolved_output[key] = expr
+        finally:
+            # Restore previous fan_in state even if evaluation fails
+            context.fan_in = prev_fan_in
 
         return StepResult(
             status=StepStatus.COMPLETED,

workflows/PUBLISHING.md

@@ -86,7 +86,7 @@ steps:
 
 **Validation Checklist**:
 
-- ✅ `id` is lowercase with hyphens only (matches `^[a-z0-9][a-z0-9-]*[a-z0-9]$`)
+- ✅ `id` is lowercase alphanumeric with hyphens (single-character IDs are allowed)
 - ✅ `version` follows semantic versioning (X.Y.Z)
 - ✅ `description` is concise
 - ✅ All step IDs are unique