Address seventh review: string literal before pipe, type annotations, validate on install

- Move string literal check above pipe filter parsing so 'a | b' works
- Fix type annotations: input_values list[str] | None, run_id str | None
- Run validate_workflow() before installing from local path/URL
- Remove duplicate string literal check from expression parser

Author: mnriem

src/specify_cli/__init__.py

@@ -4092,7 +4092,7 @@ def extension_set_priority(
 @workflow_app.command("run")
 def workflow_run(
     source: str = typer.Argument(..., help="Workflow ID or YAML file path"),
-    input_values: list[str] = typer.Option(
+    input_values: list[str] | None = typer.Option(
         None, "--input", "-i", help="Input values as key=value pairs"
     ),
 ):
@@ -4191,7 +4191,7 @@ def workflow_resume(
 
 @workflow_app.command("status")
 def workflow_status(
-    run_id: str = typer.Argument(None, help="Run ID to inspect (shows all if omitted)"),
+    run_id: str | None = typer.Argument(None, help="Run ID to inspect (shows all if omitted)"),
 ):
     """Show workflow run status."""
     from .workflows.engine import WorkflowEngine
@@ -4306,6 +4306,15 @@ def _validate_and_install_local(yaml_path: Path, source_label: str) -> None:
         if not definition.id or not definition.id.strip():
             console.print("[red]Error:[/red] Workflow definition has an empty or missing 'id'")
             raise typer.Exit(1)
+
+        from .workflows.engine import validate_workflow
+        errors = validate_workflow(definition)
+        if errors:
+            console.print("[red]Error:[/red] Workflow validation failed:")
+            for err in errors:
+                console.print(f"  \u2022 {err}")
+            raise typer.Exit(1)
+
         dest_dir = workflows_dir / definition.id
         dest_dir.mkdir(parents=True, exist_ok=True)
         import shutil

src/specify_cli/workflows/expressions.py

@@ -118,7 +118,14 @@ def _evaluate_simple_expression(expr: str, namespace: dict[str, Any]) -> Any:
     """
     expr = expr.strip()
 
-    # Handle pipe filters first
+    # String literal — check before pipes and operators so quoted strings
+    # containing | or operator keywords are not mis-parsed.
+    if (expr.startswith("'") and expr.endswith("'")) or (
+        expr.startswith('"') and expr.endswith('"')
+    ):
+        return expr[1:-1]
+
+    # Handle pipe filters
     if "|" in expr:
         parts = expr.split("|", 1)
         value = _evaluate_simple_expression(parts[0].strip(), namespace)
@@ -143,13 +150,6 @@ def _evaluate_simple_expression(expr: str, namespace: dict[str, Any]) -> Any:
             return _filter_default(value)
         return value
 
-    # String literal — check before operators so quoted strings
-    # containing operator keywords (e.g. 'a in b') are not mis-parsed.
-    if (expr.startswith("'") and expr.endswith("'")) or (
-        expr.startswith('"') and expr.endswith('"')
-    ):
-        return expr[1:-1]
-
     # Boolean operators — parse 'or' first (lower precedence) so that
     # 'a or b and c' is evaluated as 'a or (b and c)'.
     if " or " in expr: