Skip to content

Commit 9bd6e5b

Browse files
authored
Update stale features.difc-proxy references in workflow prompts (#3260)
Addresses post-merge review feedback from #3257. The v0.65.3→v0.67.0 upgrade removed `features.difc-proxy` from workflow frontmatter, but 3 references to it remained in workflow prompt text (agent instructions). These told the agent to check for a config key that no longer exists. ## Changes - **`integrity-filtering-audit.md`**: Updated audit guidance (2 references) to reference `tools.github` instead of `features.difc-proxy: true` - **`shared/mcp-api-routing.md`**: Updated checklist item to reference `tools.github` configuration (integrity proxy is built-in since v0.67.0)
2 parents ad68475 + 81eb7a3 commit 9bd6e5b

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/integrity-filtering-audit.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ When classifying a **direct API bypass** warning (W-1), record:
161161
- The blocked domain(s) and block count
162162
- The workflow name and run ID
163163
- The likely cause: misconfigured `network.allowed` list, agent prompt not
164-
restricting tool use, or the workflow missing `features.difc-proxy: true`
164+
restricting tool use, or the workflow not using `tools.github` for API access
165165
- Recommended fix: strengthen agent system prompt to use MCP Gateway tools
166166
exclusively; see `shared/mcp-api-routing.md` for reusable constraint language
167167

@@ -215,8 +215,9 @@ domain(s), block count, workflow name, likely cause, and recommended fix]
215215
### Recommendations
216216

217217
[Actionable suggestions based on findings. For direct API bypass (W-1) findings,
218-
always include: 1) which workflow to investigate, 2) whether it has
219-
`features.difc-proxy: true`, 3) whether the agent prompt restricts tool use to
218+
always include: 1) which workflow to investigate, 2) whether it uses
219+
`tools.github` for API access (integrity proxy is built-in since v0.67.0),
220+
3) whether the agent prompt restricts tool use to
220221
MCP Gateway tools, and 4) a pointer to `shared/mcp-api-routing.md` for reusable
221222
constraint language to add to the workflow prompt.]
222223
```

.github/workflows/shared/mcp-api-routing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ APIs directly. Do NOT attempt to contact external AI services:
5151
Before making any API call, verify:
5252
1. ✅ Am I using a GitHub MCP server tool (not `curl`, `gh`, or HTTP fetch)?
5353
2. ✅ Is the target repository in the workflow's `allowed-repos` list?
54-
3. ✅ Is `features.difc-proxy: true` enabled in this workflow's configuration?
54+
3. ✅ Is `tools.github` configured in this workflow (integrity proxy is built-in since v0.67.0)?
5555
4. ✅ Am I NOT trying to contact any external AI service API?

0 commit comments

Comments
 (0)