Skip to content

Commit 5c20b50

Browse files
committed
Fix not keeping semantics of .optional on custom schema
1 parent 61f3c6d commit 5c20b50

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

core/src/main/scala-2/caliban/schema/SchemaDerivation.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ trait CommonSchemaDerivation[R] {
100100
val hasNonNullAnn = p.annotations.contains(GQLNonNullable())
101101

102102
if (hasNonNullAnn) (false, false)
103-
else if (hasNullableAnn || p.typeclass.nullable) (true, false)
103+
else if ((hasNullableAnn || p.typeclass.optional) && !p.typeclass.canFail) (true, false)
104104
else if (p.typeclass.canFail) (true, true)
105105
else (false, false)
106106
}

core/src/main/scala-3/caliban/schema/DerivationUtils.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ private object DerivationUtils {
132132
val hasNonNullAnn = fieldAnnotations.contains(GQLNonNullable())
133133

134134
if (hasNonNullAnn) (false, false)
135-
else if (hasNullableAnn || schema.nullable) (true, false)
135+
else if ((hasNullableAnn || schema.optional) && !schema.canFail) (true, false)
136136
else if (schema.canFail) (true, true)
137137
else (false, false)
138138
}

0 commit comments

Comments
 (0)