fix(database): remove orphan pass to fix race with transport thread

The orphan pass in sentry__cleanup_cache deleted attachment dirs without
a matching .envelope file. This raced with the transport background
thread: process_old_runs submits envelopes to the transport and deletes
the .run files, but the transport hasn't yet written the retry .envelope
to cache when the orphan pass runs, causing it to delete the attachment
dir before the TUS upload can use it.

All cleanup paths are already covered without the orphan pass: the first
pass deletes attachment dirs alongside pruned envelopes, handle_result
cleans up on retry discard, process_old_runs handles materialization
failure, and sentry__db_remove_large_attachment handles TUS success.

Also restores the cache_keep/http_retry gate on sentry__cleanup_cache
since without the orphan pass there's no reason to run it otherwise.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jpnurmi

src/sentry_core.c

@@ -290,7 +290,9 @@ sentry_init(sentry_options_t *options)
         backend->prune_database_func(backend);
     }
 
-    sentry__cleanup_cache(options);
+    if (options->cache_keep || options->http_retry) {
+        sentry__cleanup_cache(options);
+    }
 
     if (options->auto_session_tracking) {
         sentry_start_session();

src/sentry_database.c

@@ -715,38 +715,6 @@ sentry__cleanup_cache(const sentry_options_t *options)
 
     sentry_free(entries);
 
-    // Second pass: remove orphaned attachment directories
-    // (dirs without a matching .envelope, e.g. envelope deleted by
-    // materialization failure or TUS disabled)
-    iter = sentry__path_iter_directory(cache_dir);
-    while (iter && (entry = sentry__pathiter_next(iter)) != NULL) {
-        if (!sentry__path_is_dir(entry)) {
-            continue;
-        }
-        const char *dirname = sentry__path_filename(entry);
-        if (!dirname || strlen(dirname) != 36) {
-            continue;
-        }
-        bool has_envelope = false;
-        sentry_pathiter_t *fiter = sentry__path_iter_directory(cache_dir);
-        const sentry_path_t *f;
-        while (fiter && (f = sentry__pathiter_next(fiter)) != NULL) {
-            if (sentry__path_is_dir(f)) {
-                continue;
-            }
-            const char *fname = sentry__path_filename(f);
-            if (fname && strstr(fname, dirname)) {
-                has_envelope = true;
-                break;
-            }
-        }
-        sentry__pathiter_free(fiter);
-        if (!has_envelope) {
-            sentry__path_remove_all(entry);
-        }
-    }
-    sentry__pathiter_free(iter);
-
     sentry__path_free(cache_dir);
 }