Revert "Add SpanProcessor for OpenTelemetry (#875)"

This reverts commit 9887bd0.

Author: solnic

config/config.exs

@@ -10,15 +10,9 @@ if config_env() == :test do
     send_result: :sync,
     send_max_attempts: 1,
     dedup_events: false,
-    test_mode: true,
-    traces_sample_rate: 1.0
+    test_mode: true
 
   config :logger, backends: []
-
-  config :opentelemetry, span_processor: {Sentry.OpenTelemetry.SpanProcessor, []}
-
-  config :opentelemetry,
-    sampler: {Sentry.OpenTelemetry.Sampler, [drop: ["Elixir.Oban.Stager process"]]}
 end
 
 config :phoenix, :json_library, if(Code.ensure_loaded?(JSON), do: JSON, else: Jason)

lib/sentry/application.ex

@@ -26,13 +26,6 @@ defmodule Sentry.Application do
 
     integrations_config = Config.integrations()
 
-    maybe_span_storage =
-      if Config.tracing?() do
-        [Sentry.OpenTelemetry.SpanStorage]
-      else
-        []
-      end
-
     children =
       [
         {Registry, keys: :unique, name: Sentry.Transport.SenderRegistry},
@@ -46,7 +39,6 @@ defmodule Sentry.Application do
          ]}
       ] ++
         maybe_http_client_spec ++
-        maybe_span_storage ++
         [Sentry.Transport.SenderPool]
 
     cache_loaded_applications()

lib/sentry/client.ex

@@ -117,7 +117,7 @@ defmodule Sentry.Client do
 
     result_type = Keyword.get_lazy(opts, :result, &Config.send_result/0)
     client = Keyword.get_lazy(opts, :client, &Config.client/0)
-    sample_rate = Keyword.get_lazy(opts, :sample_rate, &Config.traces_sample_rate/0)
+    sample_rate = Keyword.get_lazy(opts, :sample_rate, &Config.sample_rate/0)
     before_send = Keyword.get_lazy(opts, :before_send, &Config.before_send/0)
     after_send_event = Keyword.get_lazy(opts, :after_send_event, &Config.after_send_event/0)
 

lib/sentry/config.ex

@@ -143,20 +143,6 @@ defmodule Sentry.Config do
       be used as the value for this option.
       """
     ],
-    traces_sample_rate: [
-      type: {:custom, __MODULE__, :__validate_traces_sample_rate__, []},
-      default: 0.0,
-      doc: """
-      The sample rate for transaction events. A value between `0.0` and `1.0` (inclusive).
-      A value of `0.0` means no transactions will be sampled, while `1.0` means all transactions
-      will be sampled. This value is also used to determine if tracing is enabled: if it's
-      greater than `0`, tracing is enabled.
-
-      Tracing requires OpenTelemetry packages to work. See [the
-      OpenTelemetry setup documentation](https://opentelemetry.io/docs/languages/erlang/getting-started/)
-      for guides on how to set it up.
-      """
-    ],
     included_environments: [
       type: {:or, [{:in, [:all]}, {:list, {:or, [:atom, :string]}}]},
       deprecated: "Use :dsn to control whether to send events to Sentry.",
@@ -621,9 +607,6 @@ defmodule Sentry.Config do
   @spec sample_rate() :: float()
   def sample_rate, do: fetch!(:sample_rate)
 
-  @spec traces_sample_rate() :: float()
-  def traces_sample_rate, do: fetch!(:traces_sample_rate)
-
   @spec hackney_opts() :: keyword()
   def hackney_opts, do: fetch!(:hackney_opts)
 
@@ -661,9 +644,6 @@ defmodule Sentry.Config do
   @spec integrations() :: keyword()
   def integrations, do: fetch!(:integrations)
 
-  @spec tracing?() :: boolean()
-  def tracing?, do: fetch!(:traces_sample_rate) > 0.0
-
   @spec put_config(atom(), term()) :: :ok
   def put_config(key, value) when is_atom(key) do
     unless key in @valid_keys do
@@ -763,15 +743,6 @@ defmodule Sentry.Config do
     end
   end
 
-  def __validate_traces_sample_rate__(float) do
-    if is_float(float) and float >= 0.0 and float <= 1.0 do
-      {:ok, float}
-    else
-      {:error,
-       "expected :traces_sample_rate to be a float between 0.0 and 1.0 (included), got: #{inspect(float)}"}
-    end
-  end
-
   def __validate_json_library__(nil) do
     {:error, "nil is not a valid value for the :json_library option"}
   end