fix(artifacts): Use distribution endpoint for skip reporting (EME-422)

The update_artifact endpoint silently ignored distribution_state and
distribution_skip_reason fields. Use the dedicated distribution endpoint
that accepts error_code and error_message instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: runningcode

src/launchpad/artifact_processor.py

@@ -34,7 +34,7 @@
 from launchpad.artifacts.artifact_factory import ArtifactFactory
 from launchpad.constants import (
     ArtifactType,
-    DistributionState,
+    InstallableAppErrorCode,
     PreprodFeature,
     ProcessingErrorCode,
     ProcessingErrorMessage,
@@ -424,16 +424,13 @@ def _update_distribution_skip(
         artifact_id: str,
         skip_reason: str,
     ) -> None:
-        """Update artifact with distribution skip state."""
+        """Report distribution skip via the dedicated distribution endpoint."""
         try:
-            self._sentry_client.update_artifact(
+            self._sentry_client.update_distribution_error(
                 org=organization_id,
-                project=project_id,
                 artifact_id=artifact_id,
-                data={
-                    "distribution_state": DistributionState.NOT_RAN.value,
-                    "distribution_skip_reason": skip_reason,
-                },
+                error_code=InstallableAppErrorCode.SKIPPED.value,
+                error_message=skip_reason,
             )
         except SentryClientError:
             logger.exception(f"Failed to update distribution skip for artifact {artifact_id}")

src/launchpad/constants.py

@@ -32,11 +32,12 @@ class PreprodFeature(Enum):
     BUILD_DISTRIBUTION = "build_distribution"
 
 
-# Matches PreprodArtifact.DistributionState in sentry
-class DistributionState(Enum):
-    PENDING = 0
-    COMPLETED = 1
-    NOT_RAN = 2
+# Matches InstallableApp.ErrorCode in sentry
+class InstallableAppErrorCode(Enum):
+    UNKNOWN = 0
+    NO_QUOTA = 1
+    SKIPPED = 2
+    PROCESSING_ERROR = 3
 
 
 # Health check threshold - consider unhealthy if file not touched in 60 seconds

src/launchpad/sentry_client.py

@@ -252,6 +252,24 @@ def update_artifact(self, org: str, project: str, artifact_id: str, data: Dict[s
         endpoint = f"/api/0/internal/{org}/{project}/files/preprodartifacts/{artifact_id}/update/"
         return self._make_json_request("PUT", endpoint, UpdateResponse, data=data)
 
+    def update_distribution_error(self, org: str, artifact_id: str, error_code: int, error_message: str) -> None:
+        """Report distribution error via the dedicated distribution endpoint."""
+        endpoint = f"/api/0/organizations/{org}/preprodartifacts/{artifact_id}/distribution/"
+        url = self._build_url(endpoint)
+        body = json.dumps({"error_code": error_code, "error_message": error_message}).encode("utf-8")
+
+        logger.debug(f"PUT {url}")
+        response = self.session.request(
+            method="PUT",
+            url=url,
+            data=body,
+            auth=self.auth,
+            timeout=30,
+        )
+
+        if response.status_code != 200:
+            raise SentryClientError(response=response)
+
     def upload_size_analysis_file(
         self,
         org: str,

tests/unit/artifacts/test_artifact_processor.py

@@ -9,7 +9,7 @@
 from launchpad.artifacts.apple.zipped_xcarchive import ZippedXCArchive
 from launchpad.artifacts.artifact import Artifact
 from launchpad.constants import (
-    DistributionState,
+    InstallableAppErrorCode,
     ProcessingErrorCode,
     ProcessingErrorMessage,
 )
@@ -142,7 +142,7 @@ def test_processing_error_message_enum_values(self):
 
     def test_do_distribution_unknown_artifact_type_skips(self):
         mock_sentry_client = Mock(spec=SentryClient)
-        mock_sentry_client.update_artifact.return_value = None
+        mock_sentry_client.update_distribution_error.return_value = None
         self.processor._sentry_client = mock_sentry_client
 
         unknown_artifact = Mock(spec=Artifact)
@@ -152,19 +152,16 @@ def test_do_distribution_unknown_artifact_type_skips(self):
             "test-org-id", "test-project-id", "test-artifact-id", unknown_artifact, mock_info
         )
 
-        mock_sentry_client.update_artifact.assert_called_once_with(
+        mock_sentry_client.update_distribution_error.assert_called_once_with(
             org="test-org-id",
-            project="test-project-id",
             artifact_id="test-artifact-id",
-            data={
-                "distribution_state": DistributionState.NOT_RAN.value,
-                "distribution_skip_reason": "unsupported",
-            },
+            error_code=InstallableAppErrorCode.SKIPPED.value,
+            error_message="unsupported",
         )
 
     def test_do_distribution_invalid_code_signature_skips(self):
         mock_sentry_client = Mock(spec=SentryClient)
-        mock_sentry_client.update_artifact.return_value = None
+        mock_sentry_client.update_distribution_error.return_value = None
         self.processor._sentry_client = mock_sentry_client
 
         artifact = Mock(spec=ZippedXCArchive)
@@ -174,20 +171,17 @@ def test_do_distribution_invalid_code_signature_skips(self):
 
         self.processor._do_distribution("test-org-id", "test-project-id", "test-artifact-id", artifact, mock_info)
 
-        mock_sentry_client.update_artifact.assert_called_once_with(
+        mock_sentry_client.update_distribution_error.assert_called_once_with(
             org="test-org-id",
-            project="test-project-id",
             artifact_id="test-artifact-id",
-            data={
-                "distribution_state": DistributionState.NOT_RAN.value,
-                "distribution_skip_reason": "invalid_signature",
-            },
+            error_code=InstallableAppErrorCode.SKIPPED.value,
+            error_message="invalid_signature",
         )
         mock_sentry_client.upload_installable_app.assert_not_called()
 
     def test_do_distribution_simulator_build_skips(self):
         mock_sentry_client = Mock(spec=SentryClient)
-        mock_sentry_client.update_artifact.return_value = None
+        mock_sentry_client.update_distribution_error.return_value = None
         self.processor._sentry_client = mock_sentry_client
 
         artifact = Mock(spec=ZippedXCArchive)
@@ -197,14 +191,11 @@ def test_do_distribution_simulator_build_skips(self):
 
         self.processor._do_distribution("test-org-id", "test-project-id", "test-artifact-id", artifact, mock_info)
 
-        mock_sentry_client.update_artifact.assert_called_once_with(
+        mock_sentry_client.update_distribution_error.assert_called_once_with(
             org="test-org-id",
-            project="test-project-id",
             artifact_id="test-artifact-id",
-            data={
-                "distribution_state": DistributionState.NOT_RAN.value,
-                "distribution_skip_reason": "simulator",
-            },
+            error_code=InstallableAppErrorCode.SKIPPED.value,
+            error_message="simulator",
         )
         mock_sentry_client.upload_installable_app.assert_not_called()