Format method fix and new unit tests (#671)

* Format method remake and new unit tests
Issue:97362

---------

Co-authored-by: tomas-sexenian <tsexenian@genexus.com>

Author: tomas-sexenian

common/src/main/java/com/genexus/CommonUtil.java

@@ -2327,12 +2327,11 @@ public static String format(String value, String v1, String v2, String v3, Strin
 	{
 		String[] vs = {v1, v2, v3, v4, v5, v6, v7, v8, v9};
 		StringBuffer stringBuilder = new StringBuffer();
+		int valueLength = value.length();
 		if (value != null && !value.equals(""))
 		{
-			StringTokenizer tokenizer = new StringTokenizer(value, "%", false);
 			int lastIndex = 0;
 			int index = 0;
-			int idx = 0;
 			while((index = value.indexOf('%', lastIndex)) != -1)
 			{
 				if(index > 0 && value.charAt(index - 1) == '\\')
@@ -2341,8 +2340,12 @@ public static String format(String value, String v1, String v2, String v3, Strin
 					stringBuilder.append("%");
 					lastIndex = index + 1;
 				}
-				else
+				else if (index > 0 && index < valueLength - 1 && value.charAt(index) == '%' && value.charAt(index + 1) == '%' )
 				{
+					stringBuilder.append(value.substring(lastIndex, index));
+					stringBuilder.append("%");
+					lastIndex = index + 1;
+				} else {
 					try
 					{
 						stringBuilder.append(value.substring(lastIndex, index));
@@ -2353,7 +2356,8 @@ public static String format(String value, String v1, String v2, String v3, Strin
 						stringBuilder.append("%").append(value.charAt(index+1));
 					}catch(StringIndexOutOfBoundsException e)
 					{ // Si el value termina con un %, lo ignoro
-						 lastIndex--;
+						lastIndex--;
+						stringBuilder.append("%");
 					}
 				}
 			}

java/src/test/java/com/genexus/TestCommonUtil.java

@@ -0,0 +1,117 @@
+package com.genexus;
+
+import com.genexus.specific.java.Connect;
+import com.genexus.specific.java.LogManager;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestCommonUtil {
+
+	private void initialize()
+	{
+		Connect.init();
+		LogManager.initialize(".");
+	}
+
+	@Test
+	public void testFormat() {
+		initialize();
+
+		// Test case 1: Pass in a string with no parameter markers
+		String value = "Hello world";
+		String expectedResult = "Hello world";
+		String result = CommonUtil.format(value, "", "", "", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 2: Pass in a string with maximum parameter markers
+		value = "This is a string with %1, %2, %3, %4, %5, %6, %7, %8, and %9";
+		expectedResult = "This is a string with 1, 2, 3, 4, 5, 6, 7, 8, and 9";
+		result = CommonUtil.format(value, "1", "2", "3", "4", "5", "6", "7", "8", "9");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 3: Pass in a string with one parameter marker that's also the end of the string
+		value = "Hello %1";
+		expectedResult = "Hello world";
+		result = CommonUtil.format(value, "world", "", "", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 4: Pass in a string with one parameter marker that's not the end of the string
+		value = "Alex is %1 years old";
+		expectedResult = "Alex is 26 years old";
+		result = CommonUtil.format(value, "26", "", "", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 5: Pass in a string with multiple parameter markers
+		value = "%1 is %2 years old";
+		expectedResult = "Alex is 26 years old";
+		result = CommonUtil.format(value, "Alex", "26", "", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 6: Pass in an empty string
+		value = "";
+		expectedResult = "";
+		result = CommonUtil.format(value, "1", "2", "3", "4", "5", "6", "7", "8", "9");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 7: Pass in a string containing the "/%" sequence
+		value = "%1/%2/%3";
+		expectedResult = "2022/12/31";
+		result = CommonUtil.format(value, "2022","12","31", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 8: Pass in a string containing one parameter marker followed by a % sign at the end of the string
+		value = "%1%";
+		expectedResult = "10%";
+		result = CommonUtil.format(value, "10","","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 9: Pass in a string containing one parameter marker followed by a % sign that's not at the end of the string
+		value = "The price is %1% off today";
+		expectedResult = "The price is 10% off today";
+		result = CommonUtil.format(value, "10","","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 9: Pass in a string containing multiple parameter markers separated by a % sign that also are at the end of the string
+		value = "Your discount code is %1%%2";
+		expectedResult = "Your discount code is 10%10";
+		result = CommonUtil.format(value, "10","10","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 10: Pass in a string containing multiple parameter markers separated by a % sign that are not at the end of the string
+		value = "sample text %1%%2%%3%%4%%5 sample text";
+		expectedResult = "sample text 10%10%10%10%10 sample text";
+		result = CommonUtil.format(value, "10","10","10", "10", "10", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 11: Pass in a string with a parameter marker that should be ignored
+		value = "sample text \\%1 sample text";
+		expectedResult = "sample text %1 sample text";
+		result = CommonUtil.format(value, "10","","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 12: Pass in a string with appended parameter markers at the end of the string
+		value = "Your discount code is %1%2";
+		expectedResult = "Your discount code is 1020";
+		result = CommonUtil.format(value, "10","20","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 13: Pass in a string with appended parameter markers at the middle of the string
+		value = "Your discount code is %1%2, use it within 24 hours";
+		expectedResult = "Your discount code is 1020, use it within 24 hours";
+		result = CommonUtil.format(value, "10","20","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 14: Pass in a string with appended parameter markers at the start of the string
+		value = "%1%2 is your discount code";
+		expectedResult = "1020 is your discount code";
+		result = CommonUtil.format(value, "10","20","", "", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+
+		// Test case 15: Pass in more parameter markers than needed
+		value = "%1 is %2 years old";
+		expectedResult = "Alex is 26 years old";
+		result = CommonUtil.format(value, "Alex", "26", "10", "10", "", "", "", "", "");
+		Assert.assertEquals(expectedResult, result);
+	}
+
+}