fix: resolve lint issues in e2e tests

Extract shared string constants (deployerKeda, deployerRaw,
oldFuncCLIVersion) to fix goconst warnings and add nolint:dupl
directives on intentionally duplicated BeforeEach blocks.

Author: creydr

test/e2e/e2e_test.go

@@ -30,6 +30,12 @@ const namespace = "func-operator-system"
 // serviceAccountName created for the project
 const serviceAccountName = "func-operator-controller-manager"
 
+const (
+	deployerKeda      = "keda"
+	deployerRaw       = "raw"
+	oldFuncCLIVersion = "v1.20.2"
+)
+
 // logFailedTestDetails logs function resource and controller logs on test failure
 func logFailedTestDetails(functionName, functionNamespace string) {
 	specReport := CurrentSpecReport()

test/e2e/func_deploy_test.go

@@ -664,8 +664,9 @@ var _ = Describe("Operator", func() {
 		var repoDir string
 		var functionName, functionNamespace string
 
-		BeforeEach(func() {
-			if os.Getenv("DEFAULT_DEPLOYER") == "keda" || os.Getenv("DEFAULT_DEPLOYER") == "raw" {
+		BeforeEach(func() { //nolint:dupl
+			if os.Getenv("DEFAULT_DEPLOYER") == deployerKeda ||
+				os.Getenv("DEFAULT_DEPLOYER") == deployerRaw {
 				Skip("Skipping registry auth test for Keda & raw deployer, " +
 					"as those are not supported on used CLI version (1.20.x) of this tests")
 			}
@@ -684,7 +685,7 @@ var _ = Describe("Operator", func() {
 			Expect(err).NotTo(HaveOccurred())
 			utils.DeferCleanupOnSuccess(cleanupNamespaces, functionNamespace)
 
-			oldFuncVersion := "v1.20.2"
+			oldFuncVersion := oldFuncCLIVersion
 			repoDir, err = utils.InitializeRepoWithFunction(
 				repoURL,
 				username,

test/e2e/func_middleware_update_test.go

@@ -44,8 +44,9 @@ var _ = Describe("Middleware Update", func() {
 		var repoDir string
 		var functionName, functionNamespace string
 
-		BeforeEach(func() {
-			if os.Getenv("DEFAULT_DEPLOYER") == "keda" || os.Getenv("DEFAULT_DEPLOYER") == "raw" {
+		BeforeEach(func() { //nolint:dupl
+			if os.Getenv("DEFAULT_DEPLOYER") == deployerKeda ||
+				os.Getenv("DEFAULT_DEPLOYER") == deployerRaw {
 				Skip("Skipping middleware test for Keda & raw deployer, " +
 					"as those are not supported on used CLI version (1.20.x) of this tests")
 			}
@@ -67,7 +68,7 @@ var _ = Describe("Middleware Update", func() {
 
 			// Initialize repository with function code using OLD func CLI version
 			// v1.20.2 has no middleware-version label and uses instance-compatible templates
-			oldFuncVersion := "v1.20.2"
+			oldFuncVersion := oldFuncCLIVersion
 			repoDir, err = utils.InitializeRepoWithFunction(
 				repoURL,
 				username,
@@ -253,7 +254,8 @@ var _ = Describe("Middleware Update", func() {
 		var originalConfigMapData map[string]string
 
 		BeforeEach(func() {
-			if os.Getenv("DEFAULT_DEPLOYER") == "keda" || os.Getenv("DEFAULT_DEPLOYER") == "raw" {
+			if os.Getenv("DEFAULT_DEPLOYER") == deployerKeda ||
+				os.Getenv("DEFAULT_DEPLOYER") == deployerRaw {
 				Skip("Skipping middleware test for Keda & raw deployer, " +
 					"as those are not supported on used CLI version (1.20.x) of this tests")
 			}
@@ -302,7 +304,7 @@ var _ = Describe("Middleware Update", func() {
 
 			// Initialize repository with function code using OLD func CLI version
 			// to ensure middleware will be outdated
-			oldFuncVersion := "v1.20.2"
+			oldFuncVersion := oldFuncCLIVersion
 			repoDir, err = utils.InitializeRepoWithFunction(
 				repoURL,
 				username,