From 3f2aa129d914302c1176ae4461c16e1f81cee384 Mon Sep 17 00:00:00 2001 From: Ryan Lee Date: Mon, 27 Apr 2026 21:53:52 +0000 Subject: [PATCH 1/2] Adapt manage profile settings to use the same overflow model as other views, scrolling its own internal section instead of main content, making main content hide overflow for this view instead --- src/App.scss | 28 +++++++++---------- src/common/constants/routes.constants.ts | 2 +- .../ManageProfileSettings.scss | 2 ++ 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/src/App.scss b/src/App.scss index 6ccce7f45..848dcb242 100644 --- a/src/App.scss +++ b/src/App.scss @@ -24,20 +24,6 @@ h6 { margin: 0; } -#app-root { - display: flex; - flex-direction: column; -} - -.main-content { - flex: 1; - overflow: auto; -} - -.no-overflow { - overflow: hidden; -} - #editor-root { font-family: Inter, system-ui, Avenir, Helvetica, Arial, sans-serif; line-height: 1.5; @@ -54,6 +40,20 @@ h6 { width: 100%; } + #app-root { + display: flex; + flex-direction: column; + } + + .main-content { + flex: 1; + overflow: auto; + } + + .no-overflow { + overflow: hidden; + } + h1 { font-size: 3.2em; line-height: 1.1; diff --git a/src/common/constants/routes.constants.ts b/src/common/constants/routes.constants.ts index f46ccff23..074acdc49 100644 --- a/src/common/constants/routes.constants.ts +++ b/src/common/constants/routes.constants.ts @@ -48,7 +48,7 @@ export const RESOURCE_CREATE_URLS = [ROUTES.RESOURCE_CREATE.uri]; export const MANAGE_PROFILE_SETTINGS_URLS = [ROUTES.MANAGE_PROFILE_SETTINGS.uri]; -export const FIXED_HEIGHT_VIEWS = [ROUTES.SEARCH.uri]; +export const FIXED_HEIGHT_VIEWS = [ROUTES.SEARCH.uri, ROUTES.MANAGE_PROFILE_SETTINGS.uri]; export enum QueryParams { Type = 'type', diff --git a/src/views/ManageProfileSettings/ManageProfileSettings.scss b/src/views/ManageProfileSettings/ManageProfileSettings.scss index 2513ef0bc..501fe4467 100644 --- a/src/views/ManageProfileSettings/ManageProfileSettings.scss +++ b/src/views/ManageProfileSettings/ManageProfileSettings.scss @@ -2,6 +2,8 @@ .manage-profile-settings { min-height: 100%; + height: 100%; + overflow-y: auto; display: flex; flex-direction: row; font-size: $font-md; From 5063e9fe06638342f35247d3074f69e42194432c Mon Sep 17 00:00:00 2001 From: Ryan Lee Date: Mon, 27 Apr 2026 15:01:02 -0700 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b6c5005c5..c33c7f8d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,8 +2,10 @@ ## 3.0.0 (IN PROGRESS) * Fix Sonar issues. Refs [UILD-792]. +* Fix for hidden menu bar. Refs [UILD-805]. [UILD-792]:https://folio-org.atlassian.net/browse/UILD-792 +[UILD-805]:https://folio-org.atlassian.net/browse/UILD-805 ## 2.0.1 (2026-04-23) * Fix for the case when changes to profile settings are not applied immediately. Fixes [UILD-798].