From 5e5dec40514650b6e8595c80a03e25d288512b4d Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Tue, 7 Apr 2026 09:18:50 +0530 Subject: [PATCH 1/2] add service lookup cases Signed-off-by: r0hansaxena --- pkg/utils/kubeclient/service_test.go | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/pkg/utils/kubeclient/service_test.go b/pkg/utils/kubeclient/service_test.go index 0510cf9521d..83ea599faa5 100644 --- a/pkg/utils/kubeclient/service_test.go +++ b/pkg/utils/kubeclient/service_test.go @@ -40,11 +40,11 @@ var _ = Describe("GetServiceByName", func() { namespace = "default" testServiceInputs = []*v1.Service{ { - ObjectMeta: metav1.ObjectMeta{Name: "svc1"}, + ObjectMeta: metav1.ObjectMeta{Name: "svc1", Namespace: namespace}, Spec: v1.ServiceSpec{}, }, { - ObjectMeta: metav1.ObjectMeta{Name: "svc2", Annotations: common.GetExpectedFluidAnnotations()}, + ObjectMeta: metav1.ObjectMeta{Name: "svc2", Namespace: namespace, Annotations: common.GetExpectedFluidAnnotations()}, Spec: v1.ServiceSpec{}, }, } @@ -58,16 +58,27 @@ var _ = Describe("GetServiceByName", func() { }) Context("when service doesn't exist", func() { - It("should not return an error", func() { - _, err := GetServiceByName(mockClient, "notExist", namespace) + It("should return nil service and no error", func() { + svc, err := GetServiceByName(mockClient, "notExist", namespace) Expect(err).NotTo(HaveOccurred()) + Expect(svc).To(BeNil()) }) }) Context("when service is not created by fluid", func() { - It("should not return an error", func() { - _, err := GetServiceByName(mockClient, "svc1", namespace) + It("should return the existing service", func() { + svc, err := GetServiceByName(mockClient, "svc1", namespace) Expect(err).NotTo(HaveOccurred()) + Expect(svc).NotTo(BeNil()) + Expect(svc.Name).To(Equal("svc1")) + }) + }) + + Context("when namespace doesn't match", func() { + It("should return nil service and no error", func() { + svc, err := GetServiceByName(mockClient, "svc1", "another-namespace") + Expect(err).NotTo(HaveOccurred()) + Expect(svc).To(BeNil()) }) }) }) From 851652767a54b2c4db4ee672abe9ab0d92dfd0d8 Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Tue, 7 Apr 2026 09:33:38 +0530 Subject: [PATCH 2/2] cover annotated service case Signed-off-by: r0hansaxena --- pkg/utils/kubeclient/service_test.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pkg/utils/kubeclient/service_test.go b/pkg/utils/kubeclient/service_test.go index 83ea599faa5..99a1a384bd6 100644 --- a/pkg/utils/kubeclient/service_test.go +++ b/pkg/utils/kubeclient/service_test.go @@ -74,6 +74,16 @@ var _ = Describe("GetServiceByName", func() { }) }) + Context("when service is created by fluid", func() { + It("should return the existing service", func() { + svc, err := GetServiceByName(mockClient, "svc2", namespace) + Expect(err).NotTo(HaveOccurred()) + Expect(svc).NotTo(BeNil()) + Expect(svc.Name).To(Equal("svc2")) + Expect(svc.Annotations).To(Equal(common.GetExpectedFluidAnnotations())) + }) + }) + Context("when namespace doesn't match", func() { It("should return nil service and no error", func() { svc, err := GetServiceByName(mockClient, "svc1", "another-namespace")