From 110ae4181a5bbdb0195fec891fab8c810467b034 Mon Sep 17 00:00:00 2001 From: Hongze Zhang Date: Fri, 17 Apr 2026 21:46:17 +0800 Subject: [PATCH 1/2] fix(build): absl required by s2geometry not resolved Fixes build error: ``` CMake Error at build/_deps/s2geometry-src/CMakeLists.txt:54 (find_package): By not providing "Findabsl.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "absl", but CMake did not find one. Could not find a package configuration file provided by "absl" with any of the following names: abslConfig.cmake absl-config.cmake Add the installation prefix of "absl" to CMAKE_PREFIX_PATH or set "absl_DIR" to a directory containing one of the above files. If "absl" provides a separate development package or SDK, be sure it has been installed. ``` --- CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index b19f09d7673..564f374ca62 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -763,6 +763,10 @@ if(VELOX_ENABLE_GEO) endif() if(VELOX_ENABLE_GEO) + if(NOT TARGET absl::base) + velox_set_source(absl) + velox_resolve_dependency(absl) + endif() list(PREPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/CMake/resolve_dependency_modules/s2geometry) velox_set_source(s2geometry) velox_resolve_dependency(s2geometry) From 37fb0ba6a371b6784157cf532407bfdb073fdece Mon Sep 17 00:00:00 2001 From: Hongze Zhang Date: Sat, 18 Apr 2026 20:50:01 +0800 Subject: [PATCH 2/2] address comment --- CMake/resolve_dependency_modules/s2geometry.cmake | 6 ++++++ CMakeLists.txt | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CMake/resolve_dependency_modules/s2geometry.cmake b/CMake/resolve_dependency_modules/s2geometry.cmake index ced3f23b3bf..aadb019bd8c 100644 --- a/CMake/resolve_dependency_modules/s2geometry.cmake +++ b/CMake/resolve_dependency_modules/s2geometry.cmake @@ -18,6 +18,12 @@ list(PREPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/s2geometry) # This creates a separate scope so any changed variables don't affect # the rest of the build. block() + # s2geometry needs absl. + if(NOT TARGET absl::base) + velox_set_source(absl) + velox_resolve_dependency(absl) + endif() + set(VELOX_S2GEOMETRY_BUILD_VERSION 0.12.0) set( VELOX_S2GEOMETRY_BUILD_SHA256_CHECKSUM diff --git a/CMakeLists.txt b/CMakeLists.txt index 564f374ca62..b19f09d7673 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -763,10 +763,6 @@ if(VELOX_ENABLE_GEO) endif() if(VELOX_ENABLE_GEO) - if(NOT TARGET absl::base) - velox_set_source(absl) - velox_resolve_dependency(absl) - endif() list(PREPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/CMake/resolve_dependency_modules/s2geometry) velox_set_source(s2geometry) velox_resolve_dependency(s2geometry)