Skip to content

Commit a92eb43

Browse files
MichaelCuevasfacebook-github-bot
authored andcommitted
print actual vs expected in all readdir tests
Summary: This was missing in some tests and that made it difficult to debug. Reviewed By: kmancini Differential Revision: D59654774 fbshipit-source-id: 75f221fd98876c6e1a23141f5f43820526ae82f7
1 parent 4066cfb commit a92eb43

1 file changed

Lines changed: 14 additions & 6 deletions

File tree

eden/integration/readdir_test.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -890,6 +890,8 @@ def test_readdir(self) -> None:
890890
sync=SyncBehavior(),
891891
)
892892
)
893+
print(f"expected: \n{expected}")
894+
print(f"actual: \n{actual_result}")
893895
self.assertEqual(
894896
expected,
895897
actual_result,
@@ -912,6 +914,8 @@ def test_readdir(self) -> None:
912914
sync=SyncBehavior(),
913915
)
914916
)
917+
print(f"expected: \n{expected}")
918+
print(f"actual: \n{actual}")
915919
self.assertEqual(expected, actual)
916920

917921
# non existent directory
@@ -933,6 +937,8 @@ def test_readdir(self) -> None:
933937
sync=SyncBehavior(),
934938
)
935939
)
940+
print(f"expected: \n{expected}")
941+
print(f"actual: \n{actual}")
936942
self.assertEqual(expected, actual)
937943

938944
# file
@@ -954,6 +960,8 @@ def test_readdir(self) -> None:
954960
sync=SyncBehavior(),
955961
)
956962
)
963+
print(f"expected: \n{expected}")
964+
print(f"actual: \n{actual}")
957965
self.assertEqual(expected, actual)
958966

959967
# empty string
@@ -1003,8 +1011,8 @@ def readdir_single_attr_only(self, req_attr: int) -> None:
10031011
sync=SyncBehavior(),
10041012
)
10051013
)
1006-
print(expected)
1007-
print(actual_result)
1014+
print(f"expected: \n{expected}")
1015+
print(f"actual: \n{actual_result}")
10081016

10091017
self.assertEqual(
10101018
expected,
@@ -1053,8 +1061,8 @@ def readdir_no_size_or_sha1(
10531061
sync=SyncBehavior(),
10541062
)
10551063
)
1056-
print(expected)
1057-
print(actual)
1064+
print(f"expected: \n{expected}")
1065+
print(f"actual: \n{actual}")
10581066

10591067
self.assertEqual(
10601068
expected,
@@ -1080,8 +1088,8 @@ def readdir_no_size_or_sha1(
10801088
sync=SyncBehavior(),
10811089
)
10821090
)
1083-
print(expected)
1084-
print(actual)
1091+
print(f"expected: \n{expected}")
1092+
print(f"actual: \n{actual}")
10851093
self.assertEqual(
10861094
expected,
10871095
actual.dirLists[0].get_dirListAttributeData()[entry_name],

0 commit comments

Comments
 (0)