Skip to content

Commit 41e6f47

Browse files
MichaelCuevasfacebook-github-bot
authored andcommitted
add comment explaining why fetch-tree-aux-data is enabled
Summary: # Context The new AugmentedManifest format used by Sapling and Mononoke will support looking up Trees/Blobs from CAS via (Blake3,size) pairs. We already provide a way for users to get (Blake3,size) pairs for blobs, but there is currently no easy way to get this information for trees. We want to add support to getAttributesFromFilesV2 for looking up the (Blake3,size) pairs for trees as well. To do this, we'll need to add a method for querying TreeMetadata (including size and Blake3 hashes) via the SaplingBackingStore. This initial implementation of TreeMetadata will only include the following features: 1) Ability to query TreeMetadata from the SaplingBackingStore via a getTreeMetadata endpoint 2) The ability to request TreeMetadata from the getAttributesFromFilesV2 thrift endpoint In the future, we will extend the implementation to support: 1) Automatically fetching TreeMetadata during BackingStore::getTree requests 2) Caching TreeMetadata in Eden's in-memory caches # This diff We should document why certain configs are turned on. This diff documents one config I recently enabled Reviewed By: muirdm Differential Revision: D59662771 fbshipit-source-id: 411798260aebf7f2828cf63994a1029dbee15130
1 parent 3a46c8a commit 41e6f47

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

eden/integration/lib/hgrepo.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,11 @@ def init(
292292
hgrc["remotefilelog"]["server"] = "false"
293293
hgrc["remotefilelog"]["reponame"] = "test"
294294
hgrc["remotefilelog"]["cachepath"] = cachepath
295+
296+
# We should allow fetching tree aux data along with trees
295297
hgrc.add_section("scmstore")
296298
hgrc["scmstore"]["fetch-tree-aux-data"] = "true"
299+
297300
# Some tests set these configs on their own. We shouldn't overwrite them.
298301
if not hgrc.has_section("paths"):
299302
hgrc.add_section("paths")

0 commit comments

Comments
 (0)