diff --git a/app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs b/app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs index 72d4ce83d54e7..07d394569b5db 100644 --- a/app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs +++ b/app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs @@ -11,7 +11,6 @@ use std::sync::Arc; use buck2_core::fs::project_rel_path::ProjectRelativePathBuf; -use buck2_core::soft_error; use buck2_directory::directory::directory_ref::DirectoryRef; use buck2_directory::directory::entry::DirectoryEntry; use buck2_error::BuckErrorContext; @@ -359,8 +358,7 @@ impl ArtifactTree { } } Err(e) => { - // NOTE: This shouldn't normally happen? - soft_error!("cleanup_finished_vacant", e, quiet: true).unwrap(); + tracing::debug!("cleanup_finished_vacant: {}", e); } } } diff --git a/app/buck2_execute_impl/src/materializers/deferred/command_processor.rs b/app/buck2_execute_impl/src/materializers/deferred/command_processor.rs index 8d29071814cf7..6319c577d1a21 100644 --- a/app/buck2_execute_impl/src/materializers/deferred/command_processor.rs +++ b/app/buck2_execute_impl/src/materializers/deferred/command_processor.rs @@ -548,12 +548,11 @@ impl DeferredMaterializerCommandProcessor { Some(cmd.create_clean_fut(&mut self, None, daemon_id)); } else { // This should never happen - soft_error!( + let _unused = soft_error!( "clean_stale_no_config", buck2_error!(buck2_error::ErrorTag::Tier0, "clean scheduled without being configured"), quiet: true - ) - .unwrap(); + ); } } } @@ -751,12 +750,11 @@ impl DeferredMaterializerCommandProcessor { .materializer_state_table() .update_access_times(buffer.iter().collect::>()) { - soft_error!( + let _unused = soft_error!( "materializer_materialize_error", e, quiet: true - ) - .unwrap(); + ); return "Found error while updating access times in sqlite db".to_owned(); } } @@ -1021,7 +1019,7 @@ impl DeferredMaterializerCommandProcessor { .materializer_state_table() .update_access_times(vec![&path]) { - soft_error!("has_artifact_update_time", e, quiet: true).unwrap(); + let _unused = soft_error!("has_artifact_update_time", e, quiet: true); } } } @@ -1457,7 +1455,7 @@ fn on_materialization( .materializer_state_table() .insert(path, metadata, timestamp) { - soft_error!(error_name, e, quiet: true).unwrap(); + let _unused = soft_error!(error_name, e, quiet: true); } }