fix(res.redirect): add Content-Length only if Transfer-Encoding is not present

res.redirect() always set Content-Length, even when Transfer-Encoding was already set. That is the same conflict #4893 fixed for res.send(), and Node's HTTP client rejects such responses with a parse error. Apply the same guard as res.send(): Content-Length is only set when no Transfer-Encoding header is present. Fixes #7506.

Author: princejain756

lib/response.js

@@ -857,7 +857,11 @@ res.redirect = function redirect(url) {
 
   // Respond
   this.status(status);
-  this.set('Content-Length', Buffer.byteLength(body));
+  // Because Content-Length and Transfer-Encoding can't be present in the response headers together,
+  // Content-Length should be added only if there is no Transfer-Encoding header
+  if (!this.get('Transfer-Encoding')) {
+    this.set('Content-Length', Buffer.byteLength(body));
+  }
 
   if (this.req.method === 'HEAD') {
     this.end();

test/res.redirect.js

@@ -78,6 +78,32 @@ describe('res', function(){
     })
   })
 
+  describe('when Transfer-Encoding header is present', function(){
+    var transferEncodings = [
+      'chunked',
+      'compress',
+      'deflate',
+      'gzip'
+    ];
+
+    transferEncodings.forEach(function(encoding){
+      it('should not add Content-Length header if Transfer-Encoding header is equal to ' + encoding, function(done){
+        var app = express();
+
+        app.use(function(req, res){
+          res.set('Transfer-Encoding', encoding).redirect('http://google.com');
+        });
+
+        request(app)
+          .get('/')
+          .expect(utils.shouldNotHaveHeader('Content-Length'))
+          .expect(utils.shouldHaveHeader('Transfer-Encoding'))
+          .expect('Location', 'http://google.com')
+          .expect(302, done);
+      })
+    })
+  })
+
   describe('when accepting html', function(){
     it('should respond with html', function(done){
       var app = express();