From 9fa7f40d17938b98a8ac3e05dd51224fc79a8aad Mon Sep 17 00:00:00 2001 From: honglei Date: Thu, 2 Apr 2026 16:00:17 +0800 Subject: [PATCH 1/2] fix: fix DuckDB datasource creation from Web UI --- packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py | 2 +- .../dbgpt-ext/src/dbgpt_ext/datasource/rdbms/conn_duckdb.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py b/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py index e081d98493..f109b2be51 100644 --- a/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py +++ b/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py @@ -228,7 +228,7 @@ def _sync_tables_from_db(self) -> Iterable[str]: # SQL will raise error with schema _schema = ( - None if self.db_type == DBType.SQLite.value() else self._engine.url.database + None if self.db_type in (DBType.SQLite.value(),DBType.DuckDb.value() ) else self._engine.url.database ) # including view support by adding the views as well as tables to the all # tables list if view_support is True diff --git a/packages/dbgpt-ext/src/dbgpt_ext/datasource/rdbms/conn_duckdb.py b/packages/dbgpt-ext/src/dbgpt_ext/datasource/rdbms/conn_duckdb.py index 57f7494ad2..69e69c006b 100644 --- a/packages/dbgpt-ext/src/dbgpt_ext/datasource/rdbms/conn_duckdb.py +++ b/packages/dbgpt-ext/src/dbgpt_ext/datasource/rdbms/conn_duckdb.py @@ -59,7 +59,7 @@ def from_parameters( cls, parameters: DuckDbConnectorParameters ) -> "DuckDbConnector": """Create a new DuckDBConnector from parameters.""" - return cls.from_uri(parameters.path) + return cls.from_uri(parameters.db_url()) @classmethod def from_file_path( From 44d22a4a1fe4ce532500736805f711a37584fea0 Mon Sep 17 00:00:00 2001 From: honglei Date: Thu, 2 Apr 2026 17:06:04 +0800 Subject: [PATCH 2/2] style: fix formatting in RDBMSConnector with ruff --- packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py b/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py index f109b2be51..be3ab6cabe 100644 --- a/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py +++ b/packages/dbgpt-core/src/dbgpt/datasource/rdbms/base.py @@ -228,7 +228,9 @@ def _sync_tables_from_db(self) -> Iterable[str]: # SQL will raise error with schema _schema = ( - None if self.db_type in (DBType.SQLite.value(),DBType.DuckDb.value() ) else self._engine.url.database + None + if self.db_type in (DBType.SQLite.value(), DBType.DuckDb.value()) + else self._engine.url.database ) # including view support by adding the views as well as tables to the all # tables list if view_support is True