From 94762cd0908ea943f67e0862666b550a24d2ffc1 Mon Sep 17 00:00:00 2001 From: "sj.ro" Date: Tue, 7 Feb 2023 15:25:48 +0900 Subject: [PATCH 1/5] Remove the unit test code to test codecov status check Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) --- VideoPlayer/tests/VideoPlayer-specs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/VideoPlayer/tests/VideoPlayer-specs.js b/VideoPlayer/tests/VideoPlayer-specs.js index 36be70d566..c60116801f 100644 --- a/VideoPlayer/tests/VideoPlayer-specs.js +++ b/VideoPlayer/tests/VideoPlayer-specs.js @@ -9,7 +9,7 @@ import {MediaControls} from '../../MediaPlayer'; const focus = (slider) => fireEvent.focus(slider); describe('VideoPlayer', () => { - test('should fire `onPlaying` with `playing` type when playing event is fired', () => { + /* test('should fire `onPlaying` with `playing` type when playing event is fired', () => { const handlePlaying = jest.fn(); render( @@ -44,7 +44,7 @@ describe('VideoPlayer', () => { const actual = handleControlsAvailable.mock.calls.length && handleControlsAvailable.mock.calls[0][0]; expect(actual).toMatchObject(expected); - }); + }); */ test('should not to show media slider when noslider is true', async () => { render( From 2e063fd6b9e32ac5bc88dc1b420a975feba1c275 Mon Sep 17 00:00:00 2001 From: "sj.ro" Date: Wed, 8 Feb 2023 17:25:14 +0900 Subject: [PATCH 2/5] Remove the unit test code to test codecov status check Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) --- VideoPlayer/tests/VideoPlayer-specs.js | 41 +------------------------- 1 file changed, 1 insertion(+), 40 deletions(-) diff --git a/VideoPlayer/tests/VideoPlayer-specs.js b/VideoPlayer/tests/VideoPlayer-specs.js index c60116801f..ab0b2858ef 100644 --- a/VideoPlayer/tests/VideoPlayer-specs.js +++ b/VideoPlayer/tests/VideoPlayer-specs.js @@ -1,51 +1,12 @@ import '@testing-library/jest-dom'; -import {act, createEvent, fireEvent, render, screen, waitFor} from '@testing-library/react'; +import {act, fireEvent, render, screen, waitFor} from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import VideoPlayer from '../VideoPlayer'; import {Button} from '../../Button'; import {MediaControls} from '../../MediaPlayer'; -const focus = (slider) => fireEvent.focus(slider); - describe('VideoPlayer', () => { - /* test('should fire `onPlaying` with `playing` type when playing event is fired', () => { - const handlePlaying = jest.fn(); - - render( - - ); - - const video = screen.getByTestId('videoplayer-id'); - - const playingEvent = createEvent('playing', video); - fireEvent(video, playingEvent); - - const expected = {type: 'playing'}; - const actual = handlePlaying.mock.calls.length && handlePlaying.mock.calls[0][0]; - - expect(actual).toMatchObject(expected); - }); - - test('should fire `onControlsAvailable` with `onControlsAvailable` type when screen clicked', () => { - const handleControlsAvailable = jest.fn(); - - render( - - ); - - const overlay = screen.getByTestId('videoplayer-id').nextElementSibling; - userEvent.click(overlay); - - const slider = screen.getByRole('slider', {hidden: true}); - focus(slider); // add to increase code coverage - - const expected = {type: 'onControlsAvailable'}; - const actual = handleControlsAvailable.mock.calls.length && handleControlsAvailable.mock.calls[0][0]; - - expect(actual).toMatchObject(expected); - }); */ - test('should not to show media slider when noslider is true', async () => { render( From 6633bf01d11f1acef51770d77d81f65d6e35083d Mon Sep 17 00:00:00 2001 From: "sj.ro" Date: Wed, 8 Feb 2023 17:47:10 +0900 Subject: [PATCH 3/5] Remove the unit test code to test codecov status check Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) --- VideoPlayer/tests/VideoPlayer-specs.js | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/VideoPlayer/tests/VideoPlayer-specs.js b/VideoPlayer/tests/VideoPlayer-specs.js index ab0b2858ef..37ee216a21 100644 --- a/VideoPlayer/tests/VideoPlayer-specs.js +++ b/VideoPlayer/tests/VideoPlayer-specs.js @@ -1,5 +1,5 @@ import '@testing-library/jest-dom'; -import {act, fireEvent, render, screen, waitFor} from '@testing-library/react'; +import {act, render, screen, waitFor} from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import VideoPlayer from '../VideoPlayer'; @@ -7,20 +7,6 @@ import {Button} from '../../Button'; import {MediaControls} from '../../MediaPlayer'; describe('VideoPlayer', () => { - test('should not to show media slider when noslider is true', async () => { - render( - - ); - - const overlay = screen.getByTestId('videoplayer-id').nextElementSibling; - userEvent.click(overlay); - - await screen.findByLabelText('go to previous'); - - const slider = screen.queryByRole('slider', {hidden: true}); - expect(slider).toBeNull(); - }); - test('should fire `onBack` with `onBack` type when clicking on back button', async () => { const handleBack = jest.fn(); From 277bf9352594eb552ff6a537bb24df064312eb3f Mon Sep 17 00:00:00 2001 From: sjro Date: Wed, 8 Feb 2023 18:25:27 +0900 Subject: [PATCH 4/5] Update codecov.yml --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index 6eb9211870..228c604663 100644 --- a/codecov.yml +++ b/codecov.yml @@ -9,6 +9,6 @@ coverage: threshold: 0% # advanced settings branches: - - feature/WRP-3007 + - feature/WRP-3007-1 informational: false only_pulls: true From 0191aed16376d473ba5013720e8698b96522b75b Mon Sep 17 00:00:00 2001 From: sjro Date: Wed, 8 Feb 2023 18:59:18 +0900 Subject: [PATCH 5/5] Update codecov.yml --- codecov.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/codecov.yml b/codecov.yml index 6eb9211870..1be8bbc9db 100644 --- a/codecov.yml +++ b/codecov.yml @@ -8,7 +8,5 @@ coverage: target: auto threshold: 0% # advanced settings - branches: - - feature/WRP-3007 informational: false only_pulls: true