Cannot open section: Malformed OneStore data: Unexpected node (parsing Revision): ObjectInfoDependencyOverridesFND

[starissim]

Environment

• OneNote Viewer v0.3.0 (flatpak, io.github.emsi.OneNoteViewer)
• Bundled onenote_parser 2.0.0 (emsi/onenote.rs rev 612a9f6)

Problem

Opening a .one section saved by a recent OneNote version shows "Could not read notebook":

could not parse <file>.one: Malformed OneStore data: Unexpected node (parsing Revision): ObjectInfoDependencyOverridesFND(ObjectInfoDependencyOverridesFND { data: ObjectInfoDependencyOverrideData { c8_override_count: 194, c32_override_count: 0, ... } }) (in onenote_parser/src/onestore/desktop/objects/revision.rs:208)

Root cause

The revision parser skips ObjectInfoDependencyOverridesFND only right after an ObjectGroupList and inside the object loop. When the node appears directly in the revision's file node list at another position (legitimate per MS-ONESTORE, emitted by recent OneNote versions), it hits the else branch and aborts the whole parse.

Fix

I opened a PR against the parser with a one-line fix (skip the node in the revision main loop, like DataSignatureGroupDefinitionFND): emsi/onenote.rs#1

With the patch, the failing file parses successfully. On a corpus of 171 real-world .one files the failure count dropped from 82 to 30; the remaining 30 fail identically before and after with unrelated pre-existing errors, so there are no regressions. Parser unit tests still pass.

Would it be possible to merge the parser fix and cut a new OneNote Viewer release with it?

[emsi]

Thank you, @starissim. Your diagnosis and the essential parser change are correct. ObjectInfoDependencyOverridesFND is part of the MS-ONESTORE revision grammar, so this is an onenote.rs parser compatibility fix rather than application-specific recovery code.

The original parser PR was based on OneNote Viewer's pinned integration revision. As a result, GitHub included three unrelated downstream commits in its comparison with the parser fork's clean master. Its fix commit was also unsigned, while the upstream parser requires verified commit signatures. Neither point invalidates your fix; they only prevent merging that branch directly upstream.

I have recreated the change from current upstream master, retained your contribution through a Co-authored-by trailer, added an in-memory regression test with no notebook content, signed the commit, and submitted it upstream as msiemens/onenote.rs#46. GitHub reports the signature as verified. I will track the upstream review and use the same tested change for OneNote Viewer.

[emsi]

The fix is now included in OneNote Viewer v0.3.1. This release can open the additional OneNote revision record reported here instead of rejecting the section. The corresponding reusable parser fix remains submitted upstream as msiemens/onenote.rs#46; its full CI matrix is passing.