diff --git a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs index c53de712e12c..263f48e896ab 100644 --- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs +++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProject.cs @@ -13,7 +13,7 @@ public GivenThatWeWantToBuildACppCliProject(ITestOutputHelper log) : base(log) { } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_builds_and_runs() { var testAsset = TestAssetsManager @@ -49,7 +49,7 @@ public void It_builds_and_runs() .HaveStdOutContaining("Hello, World!"); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_builds_and_runs_with_package_reference() { var targetFramework = ToolsetInfo.CurrentTargetFramework + "-windows"; @@ -84,7 +84,7 @@ public void It_builds_and_runs_with_package_reference() } } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void Given_no_restore_It_builds_cpp_project() { var testAsset = TestAssetsManager @@ -98,7 +98,7 @@ public void Given_no_restore_It_builds_cpp_project() .Pass(); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void Given_Wpf_framework_reference_It_builds_cpp_project() { var testAsset = TestAssetsManager @@ -111,7 +111,7 @@ public void Given_Wpf_framework_reference_It_builds_cpp_project() .Pass(); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_fails_with_error_message_on_EnableComHosting() { var testAsset = TestAssetsManager @@ -139,7 +139,7 @@ public void It_fails_with_error_message_on_EnableComHosting() .HaveStdOutContaining(Strings.NoSupportCppEnableComHosting); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_fails_with_error_message_on_fullframework() { var testAsset = TestAssetsManager @@ -156,7 +156,7 @@ public void It_fails_with_error_message_on_fullframework() .HaveStdOutContaining(Strings.NETFrameworkWithoutUsingNETSdkDefaults); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_fails_with_error_message_on_tfm_lower_than_3_1() { var testAsset = TestAssetsManager @@ -173,7 +173,7 @@ public void It_fails_with_error_message_on_tfm_lower_than_3_1() .HaveStdOutContaining(Strings.CppRequiresTFMVersion31); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void When_run_with_selfcontained_It_fails_with_error_message() { var testAsset = TestAssetsManager diff --git a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs index 4526d366f600..51dafdb3fad8 100644 --- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs +++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs @@ -12,7 +12,7 @@ public GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps(ITestOutputHelper private readonly Lazy _buildAsset; - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_can_generate_correct_depsJson_file() { TestAsset testAsset = _buildAsset.Value; @@ -23,7 +23,7 @@ public void It_can_generate_correct_depsJson_file() depsJsonContent.Should().Contain("NETCoreCppCliTestC.dll", "should contain transitive reference"); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_can_generate_all_runtimeconfig_files_to_output_folder() { TestAsset testAsset = _buildAsset.Value; @@ -35,7 +35,7 @@ public void It_can_generate_all_runtimeconfig_files_to_output_folder() }); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_can_generate_all_depsjson_files_to_output_folder() { TestAsset testAsset = _buildAsset.Value; diff --git a/test/Microsoft.NET.Build.Tests/SourceLinkTests.cs b/test/Microsoft.NET.Build.Tests/SourceLinkTests.cs index e36f89def8d0..3819bd59a63f 100644 --- a/test/Microsoft.NET.Build.Tests/SourceLinkTests.cs +++ b/test/Microsoft.NET.Build.Tests/SourceLinkTests.cs @@ -290,7 +290,7 @@ public void SuppressImplicitGitSourceLink_ExplicitPackage(bool multitarget) } } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void Cpp() { var testAsset = TestAssetsManager diff --git a/test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs b/test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs index faeb2cc577bf..2399f112f2c7 100644 --- a/test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs +++ b/test/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACppCliProject.cs @@ -11,7 +11,7 @@ public GivenThatWeWantToPackACppCliProject(ITestOutputHelper log) : base(log) { } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void It_cannot_pack_the_cppcliproject() { var testAsset = TestAssetsManager diff --git a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPreserveCompilationContext.cs b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPreserveCompilationContext.cs index 390e5f34668e..e2a7bd1c6cf1 100644 --- a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPreserveCompilationContext.cs +++ b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPreserveCompilationContext.cs @@ -14,8 +14,7 @@ public GivenThatWeWantToPreserveCompilationContext(ITestOutputHelper log) : base } [Theory] - // Skip = "https://github.com/dotnet/sdk/issues/53796" - //[InlineData("net46", "netstandard1.3", false)] + [InlineData("net46", "netstandard1.3", false)] [InlineData("netcoreapp2.0", "netstandard2.0", false)] [InlineData("netcoreapp2.0", "netstandard2.0", true)] [InlineData("netcoreapp3.0", "netstandard2.0", false)] diff --git a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs index c459438ea90d..d2cf293bbb66 100644 --- a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs +++ b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishACppCliProject.cs @@ -11,7 +11,7 @@ public GivenThatWeWantToPublishACppCliProject(ITestOutputHelper log) : base(log) { } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/53789")] + [FullMSBuildOnlyFact] public void When_referenced_by_csharp_project_it_publishes_and_runs() { var testAsset = TestAssetsManager