Skip to content

Commit 6500aa5

Browse files
Address review: remove #nullable enable, use IsNullOrEmpty extension
- Remove redundant #nullable enable from 6 Generator files and task file - Convert string.IsNullOrEmpty to IsNullOrEmpty extension in task Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 8c4879e commit 6500aa5

File tree

7 files changed

+1
-9
lines changed

7 files changed

+1
-9
lines changed

src/Microsoft.Android.Sdk.TrimmableTypeMap/Generator/AcwMapWriter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#nullable enable
21
using System;
32
using System.Collections.Generic;
43
using System.IO;

src/Microsoft.Android.Sdk.TrimmableTypeMap/Generator/AndroidEnumConverter.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#nullable enable
21

32
using System.Collections.Generic;
43

src/Microsoft.Android.Sdk.TrimmableTypeMap/Generator/AssemblyLevelElementBuilder.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#nullable enable
21

32
using System;
43
using System.Collections.Generic;

src/Microsoft.Android.Sdk.TrimmableTypeMap/Generator/ComponentElementBuilder.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#nullable enable
21

32
using System;
43
using System.Globalization;

src/Microsoft.Android.Sdk.TrimmableTypeMap/Generator/ManifestConstants.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#nullable enable
21

32
using System.Xml.Linq;
43

src/Microsoft.Android.Sdk.TrimmableTypeMap/Generator/PropertyMapper.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#nullable enable
21

32
using System;
43
using System.Collections.Generic;

src/Xamarin.Android.Build.Tasks/Tasks/GenerateTrimmableTypeMap.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
#nullable enable
2-
31
using System;
42
using System.Collections.Generic;
53
using System.IO;
@@ -79,7 +77,7 @@ public override bool RunTask ()
7977
}
8078

8179
ManifestConfig? manifestConfig = null;
82-
if (!string.IsNullOrEmpty (MergedAndroidManifestOutput) && !string.IsNullOrEmpty (PackageName)) {
80+
if (!MergedAndroidManifestOutput.IsNullOrEmpty () && !PackageName.IsNullOrEmpty ()) {
8381
manifestConfig = new ManifestConfig (
8482
PackageName: PackageName,
8583
ApplicationLabel: ApplicationLabel,

0 commit comments

Comments
 (0)