refactor: extract DiffPR to common package

Move the DiffPR function from notificationssection to the common package
so it can be shared between prssection and notificationssection without
duplication.

Author: sideshowbarker

internal/tui/common/diff.go

@@ -0,0 +1,31 @@
+package common
+
+import (
+	"fmt"
+	"os/exec"
+
+	tea "github.com/charmbracelet/bubbletea"
+
+	"github.com/dlvhdr/gh-dash/v4/internal/tui/constants"
+)
+
+// DiffPR opens a diff view for a PR using the gh CLI.
+// The env parameter should be the result of Config.GetFullScreenDiffPagerEnv().
+func DiffPR(prNumber int, repoName string, env []string) tea.Cmd {
+	c := exec.Command(
+		"gh",
+		"pr",
+		"diff",
+		fmt.Sprint(prNumber),
+		"-R",
+		repoName,
+	)
+	c.Env = env
+
+	return tea.ExecProcess(c, func(err error) tea.Msg {
+		if err != nil {
+			return constants.ErrMsg{Err: err}
+		}
+		return nil
+	})
+}

internal/tui/common/diff_test.go

@@ -0,0 +1,46 @@
+package common
+
+import (
+	"testing"
+)
+
+func TestDiffPR(t *testing.T) {
+	tests := []struct {
+		name     string
+		prNumber int
+		repoName string
+		wantNil  bool
+	}{
+		{
+			name:     "returns command for valid PR",
+			prNumber: 123,
+			repoName: "owner/repo",
+			wantNil:  false,
+		},
+		{
+			name:     "returns command for PR number 0",
+			prNumber: 0,
+			repoName: "owner/repo",
+			wantNil:  false,
+		},
+		{
+			name:     "returns command with hyphenated repo name",
+			prNumber: 456,
+			repoName: "my-org/my-repo",
+			wantNil:  false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			cmd := DiffPR(tt.prNumber, tt.repoName, nil)
+
+			if tt.wantNil && cmd != nil {
+				t.Errorf("DiffPR() returned non-nil, want nil")
+			}
+			if !tt.wantNil && cmd == nil {
+				t.Errorf("DiffPR() returned nil, want non-nil")
+			}
+		})
+	}
+}

internal/tui/components/notificationssection/commands.go

@@ -252,27 +252,6 @@ func (m *Model) openInBrowser() tea.Cmd {
 	)
 }
 
-// DiffPR opens a diff view for a PR. This is a standalone function that can be called
-// from ui.go with the PR details from the notification view.
-func DiffPR(ctx *context.ProgramContext, prNumber int, repoName string) tea.Cmd {
-	c := exec.Command(
-		"gh",
-		"pr",
-		"diff",
-		fmt.Sprint(prNumber),
-		"-R",
-		repoName,
-	)
-	c.Env = ctx.Config.GetFullScreenDiffPagerEnv()
-
-	return tea.ExecProcess(c, func(err error) tea.Msg {
-		if err != nil {
-			return constants.ErrMsg{Err: err}
-		}
-		return nil
-	})
-}
-
 // CheckoutPR checks out a PR. This is a standalone function that can be called
 // from ui.go with the PR details from the notification view.
 func CheckoutPR(ctx *context.ProgramContext, prNumber int, repoName string) (tea.Cmd, error) {

internal/tui/components/notificationssection/commands_test.go

@@ -14,51 +14,6 @@ func noopStartTask(task context.Task) tea.Cmd {
 	return nil
 }
 
-func TestDiffPR(t *testing.T) {
-	tests := []struct {
-		name     string
-		prNumber int
-		repoName string
-		wantNil  bool
-	}{
-		{
-			name:     "returns command for valid PR",
-			prNumber: 123,
-			repoName: "owner/repo",
-			wantNil:  false,
-		},
-		{
-			name:     "returns command for PR number 0",
-			prNumber: 0,
-			repoName: "owner/repo",
-			wantNil:  false,
-		},
-		{
-			name:     "returns command with hyphenated repo name",
-			prNumber: 456,
-			repoName: "my-org/my-repo",
-			wantNil:  false,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			ctx := &context.ProgramContext{
-				Config: &config.Config{},
-			}
-
-			cmd := DiffPR(ctx, tt.prNumber, tt.repoName)
-
-			if tt.wantNil && cmd != nil {
-				t.Errorf("DiffPR() returned non-nil, want nil")
-			}
-			if !tt.wantNil && cmd == nil {
-				t.Errorf("DiffPR() returned nil, want non-nil")
-			}
-		})
-	}
-}
-
 func TestCheckoutPR(t *testing.T) {
 	tests := []struct {
 		name      string

internal/tui/components/prssection/diff.go

@@ -1,11 +1,9 @@
 package prssection
 
 import (
-	"fmt"
-	"os/exec"
-
 	tea "github.com/charmbracelet/bubbletea"
-	"github.com/dlvhdr/gh-dash/v4/internal/tui/constants"
+
+	"github.com/dlvhdr/gh-dash/v4/internal/tui/common"
 )
 
 func (m Model) diff() tea.Cmd {
@@ -14,20 +12,5 @@ func (m Model) diff() tea.Cmd {
 		return nil
 	}
 
-	c := exec.Command(
-		"gh",
-		"pr",
-		"diff",
-		fmt.Sprint(currRowData.GetNumber()),
-		"-R",
-		m.GetCurrRow().GetRepoNameWithOwner(),
-	)
-	c.Env = m.Ctx.Config.GetFullScreenDiffPagerEnv()
-
-	return tea.ExecProcess(c, func(err error) tea.Msg {
-		if err != nil {
-			return constants.ErrMsg{Err: err}
-		}
-		return nil
-	})
+	return common.DiffPR(currRowData.GetNumber(), currRowData.GetRepoNameWithOwner(), m.Ctx.Config.GetFullScreenDiffPagerEnv())
 }

internal/tui/ui.go

@@ -583,7 +583,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 					case prview.PRActionDiff:
 						if pr := m.notificationView.GetSubjectPR(); pr != nil {
-							cmd = notificationssection.DiffPR(m.ctx, pr.GetNumber(), pr.GetRepoNameWithOwner())
+							cmd = common.DiffPR(pr.GetNumber(), pr.GetRepoNameWithOwner(), m.ctx.Config.GetFullScreenDiffPagerEnv())
 						}
 						return m, cmd