Migrate maven handler to OIDCRegistry

Replace manual OIDC credential map and mutex with the shared
OIDCRegistry type. OIDC key changes from hostname-only to full URL
(via url field), fixing credential collisions when multiple Maven
repositories share a host with different paths.

Author: kbukum1

internal/handlers/maven_repository.go

@@ -2,7 +2,6 @@ package handlers
 
 import (
 	"net/http"
-	"sync"
 
 	"github.com/elazarl/goproxy"
 
@@ -14,9 +13,8 @@ import (
 
 // MavenRepositoryHandler handles requests to maven repositories, adding auth.
 type MavenRepositoryHandler struct {
-	credentials     []mavenRepositoryCredentials
-	oidcCredentials map[string]*oidc.OIDCCredential
-	mutex           sync.RWMutex
+	credentials  []mavenRepositoryCredentials
+	oidcRegistry *oidc.OIDCRegistry
 }
 
 type mavenRepositoryCredentials struct {
@@ -29,8 +27,8 @@ type mavenRepositoryCredentials struct {
 // NewMavenRepositoryHandler returns a new MavenRepositoryHandler.
 func NewMavenRepositoryHandler(creds config.Credentials) *MavenRepositoryHandler {
 	handler := MavenRepositoryHandler{
-		credentials:     []mavenRepositoryCredentials{},
-		oidcCredentials: make(map[string]*oidc.OIDCCredential),
+		credentials:  []mavenRepositoryCredentials{},
+		oidcRegistry: oidc.NewOIDCRegistry(),
 	}
 
 	for _, cred := range creds {
@@ -40,19 +38,7 @@ func NewMavenRepositoryHandler(creds config.Credentials) *MavenRepositoryHandler
 
 		url := cred.GetString("url")
 
-		oidcCredential, _ := oidc.CreateOIDCCredential(cred)
-		if oidcCredential != nil {
-			host := cred.Host()
-			if host == "" && url != "" {
-				regURL, err := helpers.ParseURLLax(url)
-				if err == nil {
-					host = regURL.Hostname()
-				}
-			}
-			if host != "" {
-				handler.oidcCredentials[host] = oidcCredential
-				logging.RequestLogf(nil, "registered %s OIDC credentials for maven repository: %s", oidcCredential.Provider(), host)
-			}
+		if _, _, ok := handler.oidcRegistry.Register(cred, []string{"url"}, "maven repository"); ok {
 			continue
 		}
 
@@ -81,7 +67,7 @@ func (h *MavenRepositoryHandler) HandleRequest(req *http.Request, ctx *goproxy.P
 	}
 
 	// Try OIDC credentials first
-	if oidc.TryAuthOIDCRequestWithPrefix(&h.mutex, h.oidcCredentials, req, ctx) {
+	if h.oidcRegistry.TryAuth(req, ctx) {
 		return req, nil
 	}
 

internal/handlers/oidc_handling_test.go

@@ -627,7 +627,7 @@ func TestOIDCURLsAreAuthenticated(t *testing.T) {
 			},
 			urlMocks: []mockHttpRequest{},
 			expectedLogLines: []string{
-				"registered aws OIDC credentials for maven repository: maven.example.com",
+				"registered aws OIDC credentials for maven repository: https://maven.example.com/packages",
 			},
 			urlsToAuthenticate: []string{
 				"https://maven.example.com/packages/some-package",
@@ -649,7 +649,7 @@ func TestOIDCURLsAreAuthenticated(t *testing.T) {
 			},
 			urlMocks: []mockHttpRequest{},
 			expectedLogLines: []string{
-				"registered azure OIDC credentials for maven repository: maven.example.com",
+				"registered azure OIDC credentials for maven repository: https://maven.example.com/packages",
 			},
 			urlsToAuthenticate: []string{
 				"https://maven.example.com/packages/some-package",
@@ -670,7 +670,7 @@ func TestOIDCURLsAreAuthenticated(t *testing.T) {
 			},
 			urlMocks: []mockHttpRequest{},
 			expectedLogLines: []string{
-				"registered jfrog OIDC credentials for maven repository: jfrog.example.com",
+				"registered jfrog OIDC credentials for maven repository: https://jfrog.example.com/packages",
 			},
 			urlsToAuthenticate: []string{
 				"https://jfrog.example.com/packages/some-package",
@@ -693,7 +693,7 @@ func TestOIDCURLsAreAuthenticated(t *testing.T) {
 			},
 			urlMocks: []mockHttpRequest{},
 			expectedLogLines: []string{
-				"registered cloudsmith OIDC credentials for maven repository: cloudsmith.example.com",
+				"registered cloudsmith OIDC credentials for maven repository: https://cloudsmith.example.com",
 			},
 			urlsToAuthenticate: []string{
 				"https://cloudsmith.example.com/some-package",