Skip to content

Commit c6af3fa

Browse files
authored
Pin Modal torch-latest to OCI and cover PR open events (#8770)
Pin Modal Sandbox placement to OCI and report the required PR-side check for opened and reopened pull requests. Keep GPU testing on merge queue, nightly, and manual runs. Signed-off-by: Masahiro Tanaka <tanaka.masahiro@gmail.com>
1 parent 991ccf0 commit c6af3fa

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

‎.github/workflows/modal-torch-latest.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ on:
4545
- cron: '0 10 * * *'
4646

4747
pull_request_target:
48-
types: [review_requested, ready_for_review, synchronize]
48+
types: [opened, reopened, review_requested, ready_for_review, synchronize]
4949
branches:
5050
- master
5151

‎ci/test_torch_latest.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,7 @@ def test_remote_plan_is_structural_and_preserves_order_and_scope():
427427

428428
def test_sandbox_kwargs_are_fixed_and_secret_free():
429429
kwargs = torch_latest.build_sandbox_kwargs("image")
430+
assert kwargs["cloud"] == "oci"
430431
assert kwargs["gpu"] == "l40s:2"
431432
assert kwargs["timeout"] == 7200
432433
assert torch_latest.SANDBOX_ACQUIRE_TIMEOUT_SECONDS == 1800

‎ci/torch_latest.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ def build_sandbox_kwargs(image: Any) -> dict[str, Any]:
439439
"unencrypted_ports": [],
440440
"proxy": None,
441441
"block_network": False,
442+
"cloud": "oci",
442443
"gpu": "l40s:2",
443444
"timeout": SANDBOX_TIMEOUT_SECONDS,
444445
}

0 commit comments

Comments
 (0)