fix(compare-dbalogin): add null check after connection attempt

potatoqualitee · potatoqualitee · commit cb2e39f9c718 · 2026-04-15T19:44:31.000+02:00
- Add check to skip processing if destServer is null after connection
- Prevents null reference errors when destination server connection fails
- Improves robustness when connecting to unavailable instances
diff --git a/public/Compare-DbaLogin.ps1 b/public/Compare-DbaLogin.ps1
@@ -135,6 +135,7 @@ function Compare-DbaLogin {
             } catch {
                 Stop-Function -Message "Failure connecting to $destInstance" -Category ConnectionError -ErrorRecord $_ -Target $destInstance -Continue
             }
+            if ($null -eq $destServer) { continue }
 
             $splatGetDest = @{
                 SqlInstance        = $destServer

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ function Compare-DbaLogin {`
`135`	`135`	`} catch {`
`136`	`136`	`Stop-Function -Message "Failure connecting to $destInstance" -Category ConnectionError -ErrorRecord $_ -Target $destInstance -Continue`
`137`	`137`	`}`
	`138`	`+ if ($null -eq $destServer) { continue }`
`138`	`139`
`139`	`140`	`$splatGetDest = @{`
`140`	`141`	`SqlInstance = $destServer`