Skip to content

Commit 73177d7

Browse files
Publish-DbaDacPackage - Fix CommandTimeout: set on DacServices object, not connection string
CommandTimeout is not a valid SQL connection string keyword and caused: 'Keyword not supported: commandtimeout' Set it via DacServices.CommandTimeout property after instantiation instead. Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
1 parent 242f1bf commit 73177d7

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

public/Publish-DbaDacPackage.ps1

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,13 +330,10 @@ function Publish-DbaDacPackage {
330330
if ($connString -notmatch "Database=") {
331331
$connString = "$connString;Database=$dbName"
332332
}
333-
if ($connString -notmatch "CommandTimeout=") {
334-
$connString = "$connString;CommandTimeout=$CommandTimeout"
335-
}
336-
337333
#Create services object
338334
try {
339335
$dacServices = New-Object Microsoft.SqlServer.Dac.DacServices $connString
336+
$dacServices.CommandTimeout = $CommandTimeout
340337
} catch {
341338
Stop-Function -Message "Error occurred while establishing connection to $instance" -Category ConnectionError -ErrorRecord $_ -Target $server -Continue
342339
}

0 commit comments

Comments
 (0)