refactor(sdk): define FFINetwork in rs-sdk-ffi

`FFINetwork` came from rust-dashcore's `dash-network` crate behind its `ffi` feature, which dashpay/rust-dashcore#776 removes together with `key-wallet-ffi`. `rs-sdk-ffi` now defines the enum and its `Network` conversions itself, and every other FFI crate takes it from there.

The generated C definition is unchanged (`FFINetwork_Mainnet` and so on), so Swift and Kotlin need no code change. `build_ios.sh` stops shipping `dash-network.h`, and nothing enables `dash-network`'s `ffi` feature any more. Its unused `dashcore_network_get_name` export goes with it.

Author: xdustinface

Cargo.lock

@@ -3,10 +3,10 @@ package org.dashfoundation.dashsdk
 /**
  * The Dash network the SDK is operating on.
  *
- * Kotlin mirror of `dash-network`'s `FFINetwork` C-ABI enum — the single
+ * Kotlin mirror of `rs-sdk-ffi`'s `FFINetwork` C-ABI enum — the single
  * network type every Rust FFI surface takes/returns. Port of
  * `SwiftDashSDK/DashNetwork.swift`; [ffiValue] ordinals must stay in sync
- * with `dash-network/src/ffi.rs`.
+ * with `rs-sdk-ffi/src/types.rs`.
  */
 enum class Network(val ffiValue: Int) {
     MAINNET(0),

packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/Network.kt

@@ -9,7 +9,7 @@ class NetworkTest {
 
     @Test
     fun ffiOrdinalsMatchDashNetworkFfiEnum() {
-        // Must stay in sync with dash-network/src/ffi.rs.
+        // Must stay in sync with rs-sdk-ffi/src/types.rs.
         assertEquals(0, Network.MAINNET.ffiValue)
         assertEquals(1, Network.TESTNET.ffiValue)
         assertEquals(2, Network.DEVNET.ffiValue)

packages/kotlin-sdk/sdk/src/test/kotlin/org/dashfoundation/dashsdk/NetworkTest.kt

@@ -32,7 +32,6 @@ tokio-metrics = { workspace = true, optional = true }
 # Core dependencies (for Network type)
 dashcore = { workspace = true }
 key-wallet = { workspace = true, features = ["bincode"] }
-dash-network = { workspace = true, features = ["ffi"] }
 
 # For the glue impl of platform-wallet's async `DrainCryptoProvider` trait over
 # the resolver-backed signer (deferred-crypto drain FFI).

packages/rs-platform-wallet-ffi/Cargo.toml

@@ -5,8 +5,7 @@ use std::os::raw::c_char;
 // `FFINetwork` is the `#[repr(C)]` mirror cbindgen emits for callers.
 // Every FFI entry point in this crate takes / returns `FFINetwork`;
 // internal Rust code converts via `Network::from(ffi)` / `ffi.into()`.
-pub use dash_network::ffi::FFINetwork;
-pub use dash_network::Network;
+pub use rs_sdk_ffi::{FFINetwork, Network};
 
 /// Block time structure
 #[repr(C)]

packages/rs-platform-wallet-ffi/src/types.rs

@@ -43,9 +43,9 @@ key-wallet = { workspace = true }
 # FFI. Single source of truth — reused, not re-implemented.
 platform-encryption = { path = "../rs-platform-encryption" }
 
-# Single source of truth for the Network enum and its `#[repr(C)]`
-# FFI variant, both used directly across this crate's FFI surface.
-dash-network = { workspace = true, features = ["ffi"] }
+# Single source of truth for the Network enum. `FFINetwork` in
+# `src/types.rs` is its `#[repr(C)]` mirror.
+dash-network = { workspace = true }
 
 # FFI and serialization
 serde = { version = "1.0", features = ["derive"] }

packages/rs-sdk-ffi/Cargo.toml

@@ -40,9 +40,42 @@ pub type DashSDKPublicKeyHandle = IdentityPublicKeyHandle;
 // is the `#[repr(C)]` mirror cbindgen emits for callers. Every FFI
 // entry point in this crate takes / returns `FFINetwork`; internal
 // Rust code converts via `Network::from(ffi)` / `ffi.into()`.
-pub use dash_network::ffi::FFINetwork;
 pub use dash_network::Network;
 
+/// C-ABI mirror of [`Network`].
+///
+/// cbindgen:prefix-with-name
+#[repr(C)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum FFINetwork {
+    Mainnet = 0,
+    Testnet = 1,
+    Devnet = 2,
+    Regtest = 3,
+}
+
+impl From<Network> for FFINetwork {
+    fn from(network: Network) -> Self {
+        match network {
+            Network::Mainnet => FFINetwork::Mainnet,
+            Network::Testnet => FFINetwork::Testnet,
+            Network::Devnet => FFINetwork::Devnet,
+            Network::Regtest => FFINetwork::Regtest,
+        }
+    }
+}
+
+impl From<FFINetwork> for Network {
+    fn from(network: FFINetwork) -> Self {
+        match network {
+            FFINetwork::Mainnet => Network::Mainnet,
+            FFINetwork::Testnet => Network::Testnet,
+            FFINetwork::Devnet => Network::Devnet,
+            FFINetwork::Regtest => Network::Regtest,
+        }
+    }
+}
+
 /// SDK configuration passed from C callers.
 ///
 /// # Pointer lifetime

packages/rs-sdk-ffi/src/types.rs

@@ -10,7 +10,6 @@ crate-type = ["staticlib", "cdylib"]
 [dependencies]
 platform-wallet-ffi = { path = "../rs-platform-wallet-ffi" }
 rs-sdk-ffi = { path = "../rs-sdk-ffi" }
-dash-network = { workspace = true, features = ["ffi"] }
 
 [features]
 default = []

packages/rs-unified-sdk-ffi/Cargo.toml

@@ -1,3 +1,2 @@
-pub use dash_network;
 pub use platform_wallet_ffi;
 pub use rs_sdk_ffi;

packages/rs-unified-sdk-ffi/src/lib.rs

@@ -15,7 +15,6 @@ crate-type = ["cdylib"]
 jni = "0.21"
 rs-sdk-ffi = { path = "../rs-sdk-ffi" }
 platform-wallet-ffi = { path = "../rs-platform-wallet-ffi" }
-dash-network = { workspace = true, features = ["ffi"] }
 log = "0.4"
 zeroize = "1"