refactor(sdk): drop the key-wallet-ffi dependency (#5728)

Author: xdustinface

Cargo.lock

@@ -74,7 +74,6 @@ dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf
 dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }
 dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }
 key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }
-key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }
 key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }
 dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }
 dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "7329126edf27fb0356c444888ad1207bdfa2e39a" }

Cargo.toml

@@ -442,7 +442,7 @@ and the [WASM](../wasm/binding-patterns.md) chapters.
 
 ### FFI and mobile SDKs hold no business logic
 
-The FFI crates (`rs-sdk-ffi`, `rs-platform-wallet-ffi`, `key-wallet-ffi`) and
+The FFI crates (`rs-sdk-ffi`, `rs-platform-wallet-ffi`) and
 the Swift and Kotlin SDKs do three things: persist Rust-emitted state, load it
 for views, and call a function that already exists in a Rust library. If the
 wrapper is deciding anything (an index, a derivation path, which key, how

book/src/contributing/coding-conventions.md

@@ -3,10 +3,10 @@ package org.dashfoundation.dashsdk
 /**
  * The Dash network the SDK is operating on.
  *
- * Kotlin mirror of `dash-network`'s `FFINetwork` C-ABI enum — the single
+ * Kotlin mirror of `rs-sdk-ffi`'s `FFINetwork` C-ABI enum — the single
  * network type every Rust FFI surface takes/returns. Port of
  * `SwiftDashSDK/DashNetwork.swift`; [ffiValue] ordinals must stay in sync
- * with `dash-network/src/ffi.rs`.
+ * with `rs-sdk-ffi/src/types.rs`.
  */
 enum class Network(val ffiValue: Int) {
     MAINNET(0),

packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/Network.kt

@@ -8,8 +8,8 @@ import org.junit.Test
 class NetworkTest {
 
     @Test
-    fun ffiOrdinalsMatchDashNetworkFfiEnum() {
-        // Must stay in sync with dash-network/src/ffi.rs.
+    fun ffiOrdinalsMatchSdkFfiEnum() {
+        // Must stay in sync with rs-sdk-ffi/src/types.rs.
         assertEquals(0, Network.MAINNET.ffiValue)
         assertEquals(1, Network.TESTNET.ffiValue)
         assertEquals(2, Network.DEVNET.ffiValue)

packages/kotlin-sdk/sdk/src/test/kotlin/org/dashfoundation/dashsdk/NetworkTest.kt

@@ -32,7 +32,6 @@ tokio-metrics = { workspace = true, optional = true }
 # Core dependencies (for Network type)
 dashcore = { workspace = true }
 key-wallet = { workspace = true, features = ["bincode"] }
-dash-network = { workspace = true, features = ["ffi"] }
 
 # For the glue impl of platform-wallet's async `DrainCryptoProvider` trait over
 # the resolver-backed signer (deferred-crypto drain FFI).

packages/rs-platform-wallet-ffi/Cargo.toml

@@ -28,9 +28,7 @@ use platform_wallet::parse_mnemonic_any_language;
 ///
 /// Discriminants match `key_wallet::Language`'s declaration order (and the
 /// Swift `MnemonicLanguage` raw values) so the three enums stay numerically
-/// aligned. Deliberately a distinct name from key-wallet-ffi's `FFILanguage`
-/// (same 0–9 values): both headers are exported by the single `DashSDKFFI`
-/// umbrella module, so reusing the name would be a C enumerator redefinition.
+/// aligned.
 #[repr(C)]
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum FFIMnemonicLanguage {

packages/rs-platform-wallet-ffi/src/mnemonic_words.rs

@@ -5,8 +5,7 @@ use std::os::raw::c_char;
 // `FFINetwork` is the `#[repr(C)]` mirror cbindgen emits for callers.
 // Every FFI entry point in this crate takes / returns `FFINetwork`;
 // internal Rust code converts via `Network::from(ffi)` / `ffi.into()`.
-pub use dash_network::ffi::FFINetwork;
-pub use dash_network::Network;
+pub use rs_sdk_ffi::{FFINetwork, Network};
 
 /// Block time structure
 #[repr(C)]

packages/rs-platform-wallet-ffi/src/types.rs

@@ -44,9 +44,9 @@ key-wallet = { workspace = true }
 # FFI. Single source of truth — reused, not re-implemented.
 platform-encryption = { path = "../rs-platform-encryption" }
 
-# Single source of truth for the Network enum and its `#[repr(C)]`
-# FFI variant, both used directly across this crate's FFI surface.
-dash-network = { workspace = true, features = ["ffi"] }
+# Single source of truth for the Network enum. `FFINetwork` in
+# `src/types.rs` is its `#[repr(C)]` mirror.
+dash-network = { workspace = true }
 
 # FFI and serialization
 serde = { version = "1.0", features = ["derive"] }

packages/rs-sdk-ffi/Cargo.toml

@@ -204,11 +204,6 @@ result = lib.dash_sdk_create(byref(config))
 - `dash_spv_ffi_client_broadcast_transaction()` - Broadcast transaction
 - `dash_spv_ffi_client_get_transaction()` - Get transaction details
 
-#### HD Wallet Functions
-- `key_wallet_ffi_mnemonic_generate()` - Generate HD wallet mnemonic
-- `key_wallet_ffi_derive_address()` - Derive addresses from HD wallet
-- `key_wallet_ffi_sign_transaction()` - Sign transactions with HD keys
-
 ## Architecture
 
 The FFI layer follows these principles: