refactor(tools): read masternode keys from the running wallet

The masternode owner and voting key screens read the running wallet's provider address pool, and `providerKeyAtIndex` derives the keys. The pool a throwaway KeyWallet wallet derived from the phrase is gone.

An empty pool now means the wallet has no provider account of that kind, and `providerKeyAtIndex` throws for it. `poolIsLive` becomes a computed `hasProviderPool`, and the voting screen's banner says the wallet has no masternode voting key account instead of asking the user to finish syncing. The banner's catalog entry is English in every locale until it is translated again.

`SwiftDashSDKHost.derivationWallet()`, the throwaway key-wallet these screens and CrowdNode used, has no callers left and is deleted.

Author: xdustinface

DashWallet/Sources/Infrastructure/SwiftDashSDK/SwiftDashSDKHost.swift

@@ -593,31 +593,6 @@ final class SwiftDashSDKHost {
         return persistedMnemonics().contains { Mnemonic.normalizePhrase($0.mnemonic) == typed }
     }
 
-    /// Throwaway key-wallet stack (manager + wallet) for path-based key
-    /// derivation, built from the persisted mnemonic of the host's active
-    /// wallet. Separate from the running `PlatformWalletManager` — key
-    /// derivation lives in the `WalletManager`/`Wallet` FFI surface, which
-    /// the runtime handles don't expose. The instances derive keys locally
-    /// (no networking, no persistence); drop them when done.
-    ///
-    /// Consumers: the masternode Owner/Voting key deriver and CrowdNode
-    /// message signing. Returns nil when no wallet is bound/running or the
-    /// mnemonic can't be read (logged).
-    func derivationWallet() -> (manager: WalletManager, wallet: Wallet, walletId: Data)? {
-        guard let hostWalletId = wallet?.walletId, let network = runningNetwork else {
-            Self.logger.warning("🪺 HOST :: derivationWallet — no bound wallet/network")
-            return nil
-        }
-        guard let mnemonic = try? WalletStorage().retrieveMnemonic(for: hostWalletId),
-              let manager = try? WalletManager(network: network),
-              let walletId = try? manager.addWallet(mnemonic: mnemonic),
-              let derivationWallet = (try? manager.getWallet(id: walletId)) ?? nil else {
-            Self.logger.error("🪺 HOST :: derivationWallet — key-wallet bootstrap failed")
-            return nil
-        }
-        return (manager: manager, wallet: derivationWallet, walletId: walletId)
-    }
-
     // MARK: - Lifecycle
 
     enum HostError: LocalizedError {

DashWallet/Sources/Infrastructure/SwiftDashSDK/Voting/MasternodeVoterRegistry.swift

@@ -93,10 +93,10 @@ final class MasternodeVoterRegistry {
     /// Outcome of a votable-node resolution.
     ///
     /// `mayBeIncomplete` says the answer cannot be trusted as exhaustive: the
-    /// voting address pool was read from the degraded fallback (gap-limit
-    /// deep) *and* at least one active registration went unmatched, so a node
-    /// this wallet really can vote with may be missing from `nodes`. The UI
-    /// says so rather than presenting a short list as the full picture.
+    /// running wallet has no provider voting account *and* at least one active
+    /// registration went unmatched, so a node this wallet really can vote with
+    /// may be missing from `nodes`. The UI says so rather than presenting a
+    /// short list as the full picture.
     struct Resolution {
         let nodes: [VoterNode]
         let mayBeIncomplete: Bool
@@ -163,11 +163,11 @@ final class MasternodeVoterRegistry {
                     keySource: .walletIndex(index))
             }
 
-        // Only a degraded pool read can hide a node we own; if every active
-        // registration matched, depth did not matter.
-        let mayBeIncomplete = !resolution.poolIsLive && nodes.count < eligible.count
+        // Only a missing provider voting account can hide a node we own. If
+        // every active registration matched, the account did not matter.
+        let mayBeIncomplete = !resolution.hasProviderPool && nodes.count < eligible.count
         Self.logger.info(
-            "🗳️ VOTING :: votable nodes=\(nodes.count, privacy: .public) of \(eligible.count, privacy: .public) active registrations livePool=\(resolution.poolIsLive, privacy: .public)")
+            "🗳️ VOTING :: votable nodes=\(nodes.count, privacy: .public) of \(eligible.count, privacy: .public) active registrations providerPool=\(resolution.hasProviderPool, privacy: .public)")
         // Exclusion is by the wallet's ELIGIBLE set (not just the votable
         // subset): a wallet-registered node stays out of the tracked list
         // even when its derived key didn't resolve.

DashWallet/Sources/UI/DashPay/Voting/UsernameVotingScreen.swift

@@ -53,7 +53,7 @@ struct UsernameVotingScreen: View {
             if viewModel.nodeListMayBeIncomplete {
                 VotingBanner(
                     text: NSLocalizedString(
-                        "Some of your masternodes may be missing from this list — the wallet could not read your full voting-key pool. Finish syncing and reopen this screen.",
+                        "Some of your masternodes may be missing from this list because this wallet has no masternode voting key account.",
                         comment: "Voting"),
                     tone: .warning)
             }

DashWallet/Sources/UI/Menu/Tools/Masternode Keys/DerivationPathKeys/Models/DerivationPathKeysModel.swift

@@ -185,11 +185,11 @@ extension DerivationPathKeysModel {
 /// Derives masternode provider Owner/Voting keys (ECDSA) from SwiftDashSDK,
 /// replacing DashSync's `DSAuthenticationKeysDerivationPath`.
 ///
-/// The DIP-3 paths — voting `m/9'/<coin>'/3'/1'`, owner `m/9'/<coin>'/3'/2'`
-/// (ECDSA, fully hardened account path, soft key index; coin = 5' mainnet /
-/// 1' testnet) — are resolved Rust-side by `providerKeyAtIndex`. They are NOT
-/// rebuilt here: composing them app-side is what let the account path be
-/// applied twice and produced keys off the intended branch.
+/// The DIP-3 voting and owner account paths (ECDSA, fully hardened account
+/// path, soft key index) are resolved Rust-side: `providerKeyAtIndex` derives
+/// every private key, and the addresses come from the running wallet's pool.
+/// Composing the account path app-side is what let it be applied twice and
+/// produced keys off the intended branch.
 ///
 /// Internal (not private): `MasternodeKeyUsage` reuses `address(at:)` for
 /// its owner/voting address join.
@@ -206,32 +206,17 @@ final class MasternodeProviderKeyDeriver {
     /// resolver the operator/platform families use — not a second copy of it.
     private let keyResolver: ProviderKeyResolver
 
-    /// Index → base58 address of the provider pool, snapshotted once at init.
-    /// Sourced from the running wallet (`loadLiveAddresses`), falling back to
-    /// the derivation wallet's own pool (`loadDerivationAddresses`) when the
-    /// running wallet has no provider account yet — e.g. a just-imported
-    /// wallet whose registration hasn't completed. Empty only when neither
-    /// source has a pool, in which case there are genuinely no addresses to
-    /// join against.
+    /// Index → base58 address of the running wallet's provider pool,
+    /// snapshotted once at init. Empty when the wallet has no provider account
+    /// yet, such as a just-imported wallet whose registration hasn't completed.
     private let poolAddresses: [UInt32: String]
 
     init?(key: MNKey) {
-        // The network itself is no longer read here — it selected the coin
-        // type when this class composed the DIP-3 path app-side. The resolver
-        // owns that now; the check remains because a host with no running
-        // network has no wallet to derive from either.
-        guard SwiftDashSDKHost.shared.runningNetwork != nil else {
-            return nil
-        }
-
-        let type: AccountType
         let kind: ManagedPlatformWallet.ProviderKeyKind
         switch key {
         case .voting:
-            type = .providerVotingKeys
             kind = .votingECDSA
         case .owner:
-            type = .providerOwnerKeys
             kind = .ownerECDSA
         case .operator, .evonodeOperator:
             // BLS / Ed25519 families have no address rows, so they use
@@ -243,42 +228,17 @@ final class MasternodeProviderKeyDeriver {
             return nil
         }
 
-        // The derivation stack is a THROWAWAY key-wallet built from the
-        // mnemonic (see `SwiftDashSDKHost.derivationWallet`) — it has never
-        // processed a transaction, so its pools sit at the freshly-created
-        // `DEFAULT_SPECIAL_GAP_LIMIT` depth. It backs ONLY the fallback
-        // address pool below; private keys come from `keyResolver`. Nothing
-        // outlives this initializer: the wallet is owned by `derivationManager`,
-        // which is released on return, so holding either past the pool read
-        // would leave a reference into a freed graph.
-        guard let (derivationManager, wallet, derivationWalletId) =
-                SwiftDashSDKHost.shared.derivationWallet() else {
-            return nil
-        }
-
-        // Ensure the provider account exists so the fallback pool read below
-        // can resolve it.
-        _ = try? wallet.getAccount(type: type)
-
+        self.poolAddresses = Self.loadLiveAddresses(for: key)
         self.keyResolver = keyResolver
-
-        let live = Self.loadLiveAddresses(for: key)
-        self.poolIsLive = !live.isEmpty
-        self.poolAddresses = live.isEmpty
-            ? Self.loadDerivationAddresses(
-                key: key, manager: derivationManager, walletId: derivationWalletId)
-            : live
     }
 
-    /// `true` when ``poolAddresses`` came from the running wallet's live pool.
+    /// Whether the running wallet has a provider account of this kind.
     ///
-    /// `false` means the degraded derivation-wallet fallback, which only ever
-    /// holds `DEFAULT_SPECIAL_GAP_LIMIT` entries. Consumers that merely *look
-    /// up* an index are unaffected, but consumers that **enumerate** the pool
-    /// to decide what exists — the owner/voting address joins — can silently
-    /// under-report, so they must surface the incompleteness rather than
-    /// present a short list as the whole truth.
-    let poolIsLive: Bool
+    /// Without one ``poolAddresses`` is empty and `providerKeyAtIndex` throws.
+    /// Consumers that **enumerate** the pool to decide what exists, the
+    /// owner/voting address joins, must say so rather than present an empty
+    /// list as the whole truth.
+    var hasProviderPool: Bool { !poolAddresses.isEmpty }
 
     /// Snapshot the running wallet's provider address pool — the one SPV
     /// extends as ProRegTx/ProUpRegTx matches mark indexes used, and the one
@@ -306,47 +266,6 @@ final class MasternodeProviderKeyDeriver {
         return addresses
     }
 
-    /// Degraded-path pool read from the derivation wallet itself, used when
-    /// the running wallet can't vend the account. This stack never processes
-    /// transactions, so its pool is only ever the freshly-created
-    /// `DEFAULT_SPECIAL_GAP_LIMIT` depth — enough to keep the low indexes
-    /// resolvable rather than showing nothing at all, but it is NOT a
-    /// substitute for the live pool (that shallowness is precisely the bug
-    /// this class's live read exists to fix).
-    private static func loadDerivationAddresses(
-        key: MNKey,
-        manager: WalletManager,
-        walletId: Data
-    ) -> [UInt32: String] {
-        guard let collection = manager.getManagedAccountCollection(walletId: walletId) else {
-            return [:]
-        }
-        let account: ManagedAccount?
-        switch key {
-        case .voting: account = collection.getProviderVotingKeysAccount()
-        case .owner: account = collection.getProviderOwnerKeysAccount()
-        case .operator, .evonodeOperator: account = nil
-        }
-        guard let pool = account?.getAddressPool(type: .single)
-                ?? account?.getExternalAddressPool() else {
-            return [:]
-        }
-
-        // The pool exposes no count, so walk until it stops vending. The cap
-        // is a runaway guard, not a semantic window: this pool is created at
-        // gap-limit depth and never grows here.
-        var addresses: [UInt32: String] = [:]
-        for index in 0..<Self.derivationPoolProbeCap {
-            guard let info = try? pool.getAddress(at: index) else { break }
-            addresses[index] = info.address
-        }
-        return addresses
-    }
-
-    /// Runaway guard for the fallback pool walk — far above any gap-limit
-    /// depth the derivation wallet can hold.
-    private static let derivationPoolProbeCap: UInt32 = 200
-
     func wif(at index: UInt32) -> String? {
         keyResolver.key(at: index)?.privateKeyWIF
     }
@@ -355,11 +274,7 @@ final class MasternodeProviderKeyDeriver {
         keyResolver.key(at: index)?.privateKeyHex
     }
 
-    /// The pool address at `index`. Backed by the running wallet's live pool
-    /// whenever it's available: reading the throwaway derivation wallet as
-    /// the primary source would cap every consumer at that stack's initial
-    /// 5-entry pool, hiding every masternode whose owner/voting key sits at
-    /// a deeper index.
+    /// The address at `index` of the running wallet's provider pool.
     func address(at index: UInt32) -> String? {
         poolAddresses[index]
     }

DashWallet/Sources/UI/Menu/Tools/Masternode Keys/Overview/Model/WalletKeysOverviewModel.swift

@@ -163,17 +163,17 @@ struct MasternodeKeyUsage {
         resolveAddressIndexes(family: family, targets: targets).map
     }
 
-    /// The address join plus whether it was made against the complete pool.
+    /// The address join plus whether the wallet has a provider account of
+    /// this family.
     ///
-    /// `poolIsLive == false` means the derivation-wallet fallback answered,
-    /// and that pool is only gap-limit deep — so an address that is genuinely
-    /// ours but sits at a deeper index is simply not in `map`. Callers that
-    /// present the result as "these are all of them" must say so; a caller
-    /// that only labels known rows can ignore it.
+    /// `hasProviderPool == false` means the running wallet has no provider
+    /// account to join against, so an address that is genuinely ours is
+    /// missing from `map`. Callers that present the result as "these are all
+    /// of them" must say so. A caller that only labels known rows can ignore it.
     static func resolveAddressIndexes(
         family: MNKey,
         targets: Set<String>
-    ) -> (map: [String: UInt32], poolIsLive: Bool) {
+    ) -> (map: [String: UInt32], hasProviderPool: Bool) {
         guard !targets.isEmpty,
               let deriver = MasternodeProviderKeyDeriver(key: family) else { return ([:], true) }
         var map: [String: UInt32] = [:]
@@ -183,6 +183,6 @@ struct MasternodeKeyUsage {
                   targets.contains(address) else { continue }
             map[address] = index
         }
-        return (map, deriver.poolIsLive)
+        return (map, deriver.hasProviderPool)
     }
 }

DashWallet/ar.lproj/Localizable.strings

@@ -4672,7 +4672,7 @@
 /* Maya */
 "Some coins are not available because of the halted chain" = "Some coins are not available because of the halted chain";
 
-"Some of your masternodes may be missing from this list — the wallet could not read your full voting-key pool. Finish syncing and reopen this screen." = "قد تكون بعض عقد الماسترنود لديك مفقودة من هذه القائمة — إذ تعذّر على المحفظة قراءة مجموعة مفاتيح التصويت كاملة. أكمل المزامنة ثم افتح هذه الشاشة من جديد.";
+"Some of your masternodes may be missing from this list because this wallet has no masternode voting key account." = "Some of your masternodes may be missing from this list because this wallet has no masternode voting key account.";
 
 /* Usernames */
 "Some usernames can be blocked" = "Some usernames can be blocked";

DashWallet/bg.lproj/Localizable.strings

@@ -4672,7 +4672,7 @@
 /* Maya */
 "Some coins are not available because of the halted chain" = "Some coins are not available because of the halted chain";
 
-"Some of your masternodes may be missing from this list — the wallet could not read your full voting-key pool. Finish syncing and reopen this screen." = "Някои от вашите мастерноди може да липсват в този списък — портфейлът не успя да прочете целия ви набор от ключове за гласуване. Завършете синхронизирането и отворете този екран отново.";
+"Some of your masternodes may be missing from this list because this wallet has no masternode voting key account." = "Some of your masternodes may be missing from this list because this wallet has no masternode voting key account.";
 
 /* Usernames */
 "Some usernames can be blocked" = "Some usernames can be blocked";

DashWallet/ca.lproj/Localizable.strings

@@ -4672,7 +4672,7 @@
 /* Maya */
 "Some coins are not available because of the halted chain" = "Some coins are not available because of the halted chain";
 
-"Some of your masternodes may be missing from this list — the wallet could not read your full voting-key pool. Finish syncing and reopen this screen." = "És possible que alguns dels teus masternodes faltin en aquesta llista: la cartera no ha pogut llegir tot el teu conjunt de claus de vot. Acaba la sincronització i torna a obrir aquesta pantalla.";
+"Some of your masternodes may be missing from this list because this wallet has no masternode voting key account." = "Some of your masternodes may be missing from this list because this wallet has no masternode voting key account.";
 
 /* Usernames */
 "Some usernames can be blocked" = "Some usernames can be blocked";

DashWallet/cs.lproj/Localizable.strings

@@ -4672,7 +4672,7 @@
 /* Maya */
 "Some coins are not available because of the halted chain" = "Some coins are not available because of the halted chain";
 
-"Some of your masternodes may be missing from this list — the wallet could not read your full voting-key pool. Finish syncing and reopen this screen." = "Některé z vašich masternode v tomto seznamu možná chybí — peněženka nedokázala přečíst celou vaši sadu hlasovacích klíčů. Dokončete synchronizaci a otevřete tuto obrazovku znovu.";
+"Some of your masternodes may be missing from this list because this wallet has no masternode voting key account." = "Some of your masternodes may be missing from this list because this wallet has no masternode voting key account.";
 
 /* Usernames */
 "Some usernames can be blocked" = "Some usernames can be blocked";

DashWallet/da.lproj/Localizable.strings

@@ -4672,7 +4672,7 @@
 /* Maya */
 "Some coins are not available because of the halted chain" = "Some coins are not available because of the halted chain";
 
-"Some of your masternodes may be missing from this list — the wallet could not read your full voting-key pool. Finish syncing and reopen this screen." = "Nogle af dine masternoder mangler måske på denne liste — tegnebogen kunne ikke læse hele dit sæt af afstemningsnøgler. Afslut synkroniseringen, og åbn denne skærm igen.";
+"Some of your masternodes may be missing from this list because this wallet has no masternode voting key account." = "Some of your masternodes may be missing from this list because this wallet has no masternode voting key account.";
 
 /* Usernames */
 "Some usernames can be blocked" = "Some usernames can be blocked";