From c1cf9bbb1d65af086274e670b69e2a3f63dc0ccd Mon Sep 17 00:00:00 2001 From: William Casarin Date: Thu, 6 Aug 2026 18:15:13 -0700 Subject: [PATCH] test(ci): isolate notedeck_notebook snapshot tests on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The notedeck_notebook snapshot_tests binary crashed on the Windows native test job with exit code 0xc0000005 (STATUS_ACCESS_VIOLATION) — a native process death, not a test panic: no assertion failed and no per-test result was printed. Linux and macOS were green. Its non-ignored tests are heavyweight interactive egui_kittest e2e cases (drag, connect edges, create/edit longform, rename, delete) that each spin up a full Notedeck plus Harness and loop run_ok + 25ms sleeps over asynchronous PNS-crypto nostrdb ingest. That is the same class of suite already isolated for notedeck_dave, notedeck_columns e2e, and notedeck_messages e2e, whose concurrent execution inside the parallel workspace step crashed on Windows. notedeck_notebook was the last such suite still running there. Exclude notedeck_notebook from the broad workspace test step and run it in its own one-thread step, matching the established Dave/Columns/Messages model. Coverage is unchanged (the lavapipe snapshot cases stay ignored). Changelog-None: Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/build-and-test.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index a27550315..1d8c19eab 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -25,7 +25,12 @@ jobs: run: ${{ inputs.additional-setup }} - name: Run Tests (Native Only) - run: cargo test --workspace --exclude notedeck_columns --exclude notedeck_dave --exclude notedeck_messages + run: cargo test --workspace --exclude notedeck_columns --exclude notedeck_dave --exclude notedeck_messages --exclude notedeck_notebook + env: + CI: true + + - name: Run notedeck_notebook Tests + run: cargo test -p notedeck_notebook -- --test-threads=1 env: CI: true