fix(git): avoid signing commits when gpgsign is unset

Author: cst8t

src-tauri/src/git/cli.rs

@@ -2494,16 +2494,13 @@ impl GitOperationHandler for CliGitHandler {
             &[1],
         )
         .ok()
-        .map(|value| value.trim().to_ascii_lowercase());
-        let has_signing_key =
-            Self::run_git(&["config", "--get", "user.signingkey"], Some(&repo_path))
-                .map(|value| !value.trim().is_empty())
-                .unwrap_or(false);
+        .map(|value| value.trim().to_ascii_lowercase())
+        .filter(|value| !value.is_empty());
         let should_sign = match commit_gpgsign.as_deref() {
             Some("false") | Some("0") | Some("no") | Some("off") => false,
             Some("true") | Some("1") | Some("yes") | Some("on") => true,
             Some(_) => true,
-            None => has_signing_key,
+            None => false,
         };
         if should_sign {
             #[cfg(windows)]

src-tauri/tests/git.rs

@@ -1339,6 +1339,27 @@ fn commit_creates_entry_in_log() {
     assert!(commits.iter().any(|c| c.message == "add b.txt"));
 }
 
+#[test]
+fn commit_does_not_sign_when_gpgsign_is_unset() {
+    let dir = init_repo();
+    git(dir.path(), &["config", "--unset", "commit.gpgsign"]);
+    write_file(dir.path(), "unsigned.txt", "data");
+    git(dir.path(), &["add", "unsigned.txt"]);
+
+    handler()
+        .commit_changes(&CommitRequest {
+            repo_path: dir.path().to_str().unwrap().to_string(),
+            message: "commit without signing".to_string(),
+            amend: None,
+        })
+        .expect("commit_changes should not sign when commit.gpgsign is unset");
+
+    assert_eq!(
+        git_stdout(dir.path(), &["log", "-1", "--format=%s"]),
+        "commit without signing"
+    );
+}
+
 #[test]
 fn commit_preserves_description_and_trailer_like_lines() {
     let dir = init_repo();