From f20cb0575a0b1975d25453f8926175b65f7166eb Mon Sep 17 00:00:00 2001 From: Daniel Henkel Date: Thu, 14 Sep 2023 10:15:59 +0200 Subject: [PATCH] feature: lern-fair adoptions to support our needs --- .gitignore | 3 --- packages/core/src/browser/cookie.ts | 18 ++++++------------ packages/rum/package.json | 2 +- 3 files changed, 7 insertions(+), 16 deletions(-) diff --git a/.gitignore b/.gitignore index d6b930e824..a7cac441b0 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,3 @@ -bundle -cjs -esm node_modules coverage tunnel.log diff --git a/packages/core/src/browser/cookie.ts b/packages/core/src/browser/cookie.ts index 7d9bfd1389..a4cece83ac 100644 --- a/packages/core/src/browser/cookie.ts +++ b/packages/core/src/browser/cookie.ts @@ -1,6 +1,6 @@ import { display } from '../tools/display' import { ONE_MINUTE, ONE_SECOND } from '../tools/utils/timeUtils' -import { findCommaSeparatedValue, generateUUID } from '../tools/utils/stringUtils' +import { generateUUID } from '../tools/utils/stringUtils' export interface CookieOptions { secure?: boolean @@ -8,22 +8,16 @@ export interface CookieOptions { domain?: string } -export function setCookie(name: string, value: string, expireDelay: number, options?: CookieOptions) { - const date = new Date() - date.setTime(date.getTime() + expireDelay) - const expires = `expires=${date.toUTCString()}` - const sameSite = options && options.crossSite ? 'none' : 'strict' - const domain = options && options.domain ? `;domain=${options.domain}` : '' - const secure = options && options.secure ? ';secure' : '' - document.cookie = `${name}=${value};${expires};path=/;samesite=${sameSite}${domain}${secure}` +export function setCookie(name: string, value: string, _expireDelay: number, _options?: CookieOptions) { + sessionStorage.setItem(name, value) } export function getCookie(name: string) { - return findCommaSeparatedValue(document.cookie, name) + return sessionStorage.getItem(name) } -export function deleteCookie(name: string, options?: CookieOptions) { - setCookie(name, '', 0, options) +export function deleteCookie(name: string, _options?: CookieOptions) { + sessionStorage.removeItem(name) } export function areCookiesAuthorized(options: CookieOptions): boolean { diff --git a/packages/rum/package.json b/packages/rum/package.json index de2b5d319c..ed56d098f0 100644 --- a/packages/rum/package.json +++ b/packages/rum/package.json @@ -13,7 +13,7 @@ "replace-build-env": "node ../../scripts/build/replace-build-env.js" }, "dependencies": { - "@datadog/browser-core": "4.49.0", + "@datadog/browser-core": "https://gitpkg.now.sh/corona-school/browser-sdk/packages/core?v4.49-lern-fair-packages", "@datadog/browser-rum-core": "4.49.0" }, "peerDependencies": {