Skip to content

Commit 2d699e2

Browse files
committed
Restore commented out acceptance scenario
I believe it was failing at some point, so it was commented out. https://redhat.atlassian.net/browse/EC-1023 is meant to describe the reason for the failure. It's not clear to me what the detailed story is, but this comment and the revert PR it is part of are definitely clues: #2176 (comment) Seems to work fine now, so let's bring it back. See also 4461812 to help understand the purpose of the test.
1 parent 09cafb4 commit 2d699e2

1 file changed

Lines changed: 19 additions & 20 deletions

File tree

‎features/validate_image.feature‎

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1461,26 +1461,25 @@ Feature: evaluate enterprise contract
14611461
Then the exit status should be 0
14621462
Then the output should match the snapshot
14631463

1464-
# Commented out as part of EC-1023. This will be enabled once the issue is resolved.
1465-
# Scenario: many components and sources
1466-
# Given a key pair named "known"
1467-
# And a git repository named "multitude-policy" with
1468-
# | main.rego | examples/happy_day.rego |
1469-
# And policy configuration named "ec-policy" with 10 policy sources from "git::https://${GITHOST}/git/multitude-policy.git", patched with
1470-
# | [{"op": "add", "path": "/sources/0/ruleData", "value": {"key": "value"}}] |
1471-
# | [{"op": "add", "path": "/sources/1/ruleData", "value": {"something": "here"}}] |
1472-
# | [{"op": "add", "path": "/sources/2/ruleData", "value": {"key": "different"}}] |
1473-
# | [{"op": "add", "path": "/sources/3/ruleData", "value": {"hello": "world"}}] |
1474-
# | [{"op": "add", "path": "/sources/4/ruleData", "value": {"foo": "bar"}}] |
1475-
# | [{"op": "add", "path": "/sources/5/ruleData", "value": {"peek": "poke"}}] |
1476-
# | [{"op": "add", "path": "/sources/6/ruleData", "value": {"hide": "seek"}}] |
1477-
# | [{"op": "add", "path": "/sources/7/ruleData", "value": {"hokus": "pokus"}}] |
1478-
# | [{"op": "add", "path": "/sources/8/ruleData", "value": {"mr": "mxyzptlk"}}] |
1479-
# | [{"op": "add", "path": "/sources/9/ruleData", "value": {"more": "data"}}] |
1480-
# And an Snapshot named "multitude" with 10 components signed with "known" key
1481-
# When ec command is run with "validate image --snapshot acceptance/multitude --policy acceptance/ec-policy --public-key ${known_PUBLIC_KEY} --rekor-url ${REKOR} --show-successes --output json"
1482-
# Then the exit status should be 0
1483-
# And the output should match the snapshot
1464+
Scenario: many components and sources
1465+
Given a key pair named "known"
1466+
And a git repository named "multitude-policy" with
1467+
| main.rego | examples/happy_day.rego |
1468+
And policy configuration named "ec-policy" with 10 policy sources from "git::https://${GITHOST}/git/multitude-policy.git", patched with
1469+
| [{"op": "add", "path": "/sources/0/ruleData", "value": {"key": "value"}}] |
1470+
| [{"op": "add", "path": "/sources/1/ruleData", "value": {"something": "here"}}] |
1471+
| [{"op": "add", "path": "/sources/2/ruleData", "value": {"key": "different"}}] |
1472+
| [{"op": "add", "path": "/sources/3/ruleData", "value": {"hello": "world"}}] |
1473+
| [{"op": "add", "path": "/sources/4/ruleData", "value": {"foo": "bar"}}] |
1474+
| [{"op": "add", "path": "/sources/5/ruleData", "value": {"peek": "poke"}}] |
1475+
| [{"op": "add", "path": "/sources/6/ruleData", "value": {"hide": "seek"}}] |
1476+
| [{"op": "add", "path": "/sources/7/ruleData", "value": {"hokus": "pokus"}}] |
1477+
| [{"op": "add", "path": "/sources/8/ruleData", "value": {"mr": "mxyzptlk"}}] |
1478+
| [{"op": "add", "path": "/sources/9/ruleData", "value": {"more": "data"}}] |
1479+
And an Snapshot named "multitude" with 10 components signed with "known" key
1480+
When ec command is run with "validate image --snapshot acceptance/multitude --policy acceptance/ec-policy --public-key ${known_PUBLIC_KEY} --rekor-url ${REKOR} --show-successes --output json"
1481+
Then the exit status should be 0
1482+
And the output should match the snapshot
14841483

14851484
Scenario: Format options
14861485
Given a key pair named "known"

0 commit comments

Comments
 (0)