Skip to content

Commit 260f196

Browse files
authored
fix(ci): remove trivy, bump java deps, drop armv7 (#324)
1 parent 756981b commit 260f196

File tree

4 files changed

+8
-41
lines changed

4 files changed

+8
-41
lines changed

.github/workflows/build.yaml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ jobs:
6565
- name: Checkout
6666
uses: actions/checkout@v6
6767

68-
- name: Install Trivy using install script
69-
run: |
70-
curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.37.1
71-
7268
- name: Set up Depot CLI
7369
uses: depot/setup-action@v1
7470
with:
@@ -79,25 +75,6 @@ jobs:
7975
${{ github.workspace }}/scripts/build_images.sh \
8076
--tag=ubuntu
8177
82-
- name: Scan ubuntu images
83-
run: |
84-
${{ github.workspace }}/scripts/scan_images.sh \
85-
--tag=ubuntu \
86-
--output-file=trivy-results-ubuntu.sarif
87-
88-
- name: Upload Trivy scan results to GitHub Security tab
89-
uses: github/codeql-action/upload-sarif@v4
90-
with:
91-
sarif_file: trivy-results-ubuntu.sarif
92-
category: trivy-ubuntu
93-
94-
- name: Upload Trivy scan results as an artifact
95-
uses: actions/upload-artifact@v6
96-
with:
97-
name: trivy-ubuntu
98-
path: trivy-results-ubuntu.sarif
99-
retention-days: 7
100-
10178
- name: Authenticate to Docker Hub
10279
if: github.event_name != 'pull_request'
10380
uses: docker/login-action@v3

images/java/ubuntu.Dockerfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
1010
ENV PATH=$PATH:$JAVA_HOME/bin
1111

1212
# Install Maven
13-
ARG MAVEN_VERSION=3.9.12
14-
ARG MAVEN_SHA512=0a1be79f02466533fc1a80abbef8796e4f737c46c6574ede5658b110899942a94db634477dfd3745501c80aef9aac0d4f841d38574373f7e2d24cce89d694f70
13+
ARG MAVEN_VERSION=3.9.14
14+
ARG MAVEN_SHA512=d50af8ab5e6005b46a07f0ce9d3719e67cfdf898da988a84871304cd59fb1af0fef2f99dea709e6e66f21f732f905979b5c2dce6b6860406f60a70e84d9cf0b8
1515

1616
ENV MAVEN_HOME=/usr/share/maven
1717
ENV MAVEN_CONFIG="/home/coder/.m2"
1818

1919
RUN mkdir -p $MAVEN_HOME $MAVEN_HOME/ref \
2020
&& echo "Downloading maven" \
21-
&& curl -fsSL -o /tmp/apache-maven.tar.gz https://dlcdn.apache.org/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz \
21+
&& curl -fsSL -o /tmp/apache-maven.tar.gz https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz \
2222
&& echo "Checking downloaded file hash" \
2323
&& echo "${MAVEN_SHA512} /tmp/apache-maven.tar.gz" | sha512sum -c - \
2424
&& echo "Unzipping maven" \
@@ -28,8 +28,8 @@ RUN mkdir -p $MAVEN_HOME $MAVEN_HOME/ref \
2828
&& ln -s $MAVEN_HOME/bin/mvn /usr/bin/mvn
2929

3030
# Install Gradle
31-
ENV GRADLE_VERSION=6.7
32-
ARG GRADLE_SHA512=d495bc65379d2a854d2cca843bd2eeb94f381e5a7dcae89e6ceb6ef4c5835524932313e7f30d7a875d5330add37a5fe23447dc3b55b4d95dffffa870c0b24493
31+
ENV GRADLE_VERSION=8.14.2
32+
ARG GRADLE_SHA512=5df80d555e5338c5e67fa3ad11ea8ec534416d3e1414675bdd33a8a8f342ca2cef1ffd882b2f283f56041f6d426adcc5d7d4384e6fbe3eb8edac2c967e9b0ffd
3333

3434
ENV GRADLE_HOME=/usr/bin/gradle
3535

images/node/ubuntu.Dockerfile

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,8 @@ FROM codercom/enterprise-base:ubuntu
33
# Run everything as root
44
USER root
55

6-
ARG TARGETARCH
7-
ARG TARGETVARIANT
8-
9-
# Install Node.js with platform-specific version
10-
# armv7: Node.js 22.x (last version with armv7 support)
11-
# others: Latest LTS
12-
# Ref: https://github.com/nodesource/distributions/issues/1881
13-
RUN NODE_VERSION="lts"; \
14-
if [ "${TARGETARCH}${TARGETVARIANT}" = "armv7" ]; then \
15-
NODE_VERSION="22"; \
16-
fi && \
17-
curl -sL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - && \
6+
# Install Node.js (LTS)
7+
RUN curl -sL https://deb.nodesource.com/setup_lts.x | bash - && \
188
DEBIAN_FRONTEND="noninteractive" apt-get update -y && \
199
apt-get install -y nodejs
2010

scripts/build_images.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ for image in "${IMAGES[@]}"; do
102102
continue
103103
fi
104104

105-
run_trace $DRY_RUN depot build --project "gb3p8xrshk" --load --platform linux/arm64,linux/amd64,linux/arm/v7 --save --metadata-file="build_${image}.json" \
105+
run_trace $DRY_RUN depot build --project "gb3p8xrshk" --load --platform linux/amd64,linux/arm64 --save --metadata-file="build_${image}.json" \
106106
"${docker_flags[@]}" \
107107
"$image_dir" \
108108
--file="$image_path" \

0 commit comments

Comments
 (0)